Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1392713004: ipc: Add missing includes for USE_ATTACHMENT_BROKER. (Closed)

Created:
5 years, 2 months ago by erikchen
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Add missing includes for USE_ATTACHMENT_BROKER. The preprocessor variable is defined in ipc/attachment_broker.h. There were three files that were using the variable without including the header. BUG=535711 Committed: https://crrev.com/87397e0140327124f38096d1fc88190a6154a9fd Cr-Commit-Position: refs/heads/master@{#353448}

Patch Set 1 #

Patch Set 2 : Exclude windows from logic that uses new field on IPC::Message::Header. #

Patch Set 3 : Fix unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/common/child_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_message.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M ipc/ipc_message_unittest.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
erikchen
tsepez: Please review ipc/ avi: Please review content/
5 years, 2 months ago (2015-10-08 23:31:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392713004/1
5 years, 2 months ago (2015-10-08 23:33:30 UTC) #4
Tom Sepez
lgtm
5 years, 2 months ago (2015-10-08 23:34:45 UTC) #5
Avi (use Gerrit)
lgtm
5 years, 2 months ago (2015-10-08 23:42:03 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/51335) win_chromium_compile_dbg_ng on ...
5 years, 2 months ago (2015-10-09 00:05:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392713004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392713004/20001
5 years, 2 months ago (2015-10-09 22:14:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392713004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392713004/40001
5 years, 2 months ago (2015-10-09 23:43:06 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-10 01:10:32 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-10 01:11:13 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/87397e0140327124f38096d1fc88190a6154a9fd
Cr-Commit-Position: refs/heads/master@{#353448}

Powered by Google App Engine
This is Rietveld 408576698