Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: ui/keyboard/keyboard.gyp

Issue 1392713002: Extract content dependency from keyboard code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/keyboard/keyboard.cc ('k') | ui/keyboard/keyboard_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard.gyp
diff --git a/ui/keyboard/keyboard.gyp b/ui/keyboard/keyboard.gyp
index 2f4fcdd980b1fae467973cc4d5f188179a9cfd3e..96fc1fdfa679fddc83e3d8a00d0322b5306b7339 100644
--- a/ui/keyboard/keyboard.gyp
+++ b/ui/keyboard/keyboard.gyp
@@ -49,11 +49,8 @@
'dependencies': [
'../../base/base.gyp:base',
'../../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
- '../../content/content.gyp:content_browser',
- '../../ipc/ipc.gyp:ipc',
'../../media/media.gyp:media',
'../../skia/skia.gyp:skia',
- '../../url/url.gyp:url_lib',
'../aura/aura.gyp:aura',
'../base/ime/ui_base_ime.gyp:ui_base_ime',
'../base/ui_base.gyp:ui_base',
@@ -63,27 +60,22 @@
'../events/events.gyp:events_base',
'../gfx/gfx.gyp:gfx',
'../gfx/gfx.gyp:gfx_geometry',
- '../wm/wm.gyp:wm',
'keyboard_resources',
],
'defines': [
'KEYBOARD_IMPLEMENTATION',
],
'sources': [
- 'keyboard.cc',
- 'keyboard.h',
- 'keyboard_constants.cc',
- 'keyboard_constants.h',
'keyboard_controller.cc',
'keyboard_controller.h',
'keyboard_controller_observer.h',
- 'keyboard_controller_proxy.cc',
- 'keyboard_controller_proxy.h',
'keyboard_export.h',
'keyboard_layout_manager.cc',
'keyboard_layout_manager.h',
'keyboard_switches.cc',
'keyboard_switches.h',
+ 'keyboard_ui.cc',
+ 'keyboard_ui.h',
'keyboard_util.cc',
'keyboard_util.h',
],
@@ -96,15 +88,51 @@
],
},
{
+ # GN version: //ui/keyboard:keyboard_with_content
+ 'target_name': 'keyboard_with_content',
+ 'type': '<(component)',
+ 'dependencies': [
+ 'keyboard',
+ '../../base/base.gyp:base',
+ '../../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
+ '../../content/content.gyp:content_browser',
+ '../../ipc/ipc.gyp:ipc',
+ '../../skia/skia.gyp:skia',
+ '../../url/url.gyp:url_lib',
+ '../aura/aura.gyp:aura',
+ '../base/ime/ui_base_ime.gyp:ui_base_ime',
+ '../base/ui_base.gyp:ui_base',
+ '../compositor/compositor.gyp:compositor',
+ '../events/events.gyp:dom_keycode_converter',
+ '../events/events.gyp:events',
+ '../events/events.gyp:events_base',
+ '../gfx/gfx.gyp:gfx',
+ '../gfx/gfx.gyp:gfx_geometry',
+ '../wm/wm.gyp:wm',
+ 'keyboard_resources',
+ ],
+ 'defines': [
+ 'KEYBOARD_IMPLEMENTATION',
+ ],
+ 'sources': [
+ 'content/keyboard.cc',
+ 'content/keyboard.h',
+ 'content/keyboard_constants.cc',
+ 'content/keyboard_constants.h',
+ 'content/keyboard_content_util.cc',
+ 'content/keyboard_content_util.h',
+ 'content/keyboard_ui_content.cc',
+ 'content/keyboard_ui_content.h',
+ ],
+ },
+ {
'target_name': 'keyboard_unittests',
'type': '<(gtest_target_type)',
'dependencies': [
'../../base/base.gyp:base',
'../../base/base.gyp:test_support_base',
- '../../content/content.gyp:content',
'../../skia/skia.gyp:skia',
'../../testing/gtest.gyp:gtest',
- '../../url/url.gyp:url_lib',
'../aura/aura.gyp:aura',
'../aura/aura.gyp:aura_test_support',
'../base/ime/ui_base_ime.gyp:ui_base_ime',
@@ -113,7 +141,6 @@
'../compositor/compositor.gyp:compositor_test_support',
'../gfx/gfx.gyp:gfx',
'../gfx/gfx.gyp:gfx_geometry',
- '../resources/ui_resources.gyp:ui_test_pak',
'../wm/wm.gyp:wm',
'keyboard',
],
« no previous file with comments | « ui/keyboard/keyboard.cc ('k') | ui/keyboard/keyboard_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698