Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3265)

Unified Diff: ash/shell.cc

Issue 1392713002: Extract content dependency from keyboard code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/root_window_controller_unittest.cc ('k') | ash/shell/shell_delegate_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index 20f464dd964a61c1398d8ef4c4699f8db3499582..72eb8eb32f0da8cce391e8ebf7fa6e97ddfcb9ca 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -96,7 +96,6 @@
#include "ui/gfx/geometry/size.h"
#include "ui/gfx/image/image_skia.h"
#include "ui/gfx/screen.h"
-#include "ui/keyboard/keyboard.h"
#include "ui/keyboard/keyboard_controller.h"
#include "ui/keyboard/keyboard_switches.h"
#include "ui/keyboard/keyboard_util.h"
@@ -959,12 +958,6 @@ void Shell::Init(const ShellInitParams& init_params) {
keyboard_metrics_filter_.reset(new KeyboardUMAEventFilter);
AddPreTargetHandler(keyboard_metrics_filter_.get());
- // The keyboard system must be initialized before the RootWindowController is
- // created.
-#if defined(OS_CHROMEOS)
- keyboard::InitializeKeyboard();
-#endif
-
#if defined(OS_CHROMEOS)
sticky_keys_controller_.reset(new StickyKeysController);
#endif
@@ -1105,10 +1098,8 @@ void Shell::InitKeyboard() {
keyboard::KeyboardController::GetInstance());
}
}
- keyboard::KeyboardControllerProxy* proxy =
- delegate_->CreateKeyboardControllerProxy();
keyboard::KeyboardController::ResetInstance(
- new keyboard::KeyboardController(proxy));
+ new keyboard::KeyboardController(delegate_->CreateKeyboardUI()));
}
}
« no previous file with comments | « ash/root_window_controller_unittest.cc ('k') | ash/shell/shell_delegate_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698