Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 13927002: Add callback for upload progress in Drive service and operation layer. (Closed)

Created:
7 years, 8 months ago by kinaba
Modified:
7 years, 8 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Add callback for upload progress in Drive service and operation layer. This is a preparation for moving the progress report creation task from OperationRegistry to DriveScheduler. For that purpose we need to wire the progress information to upper layer. The current patch only adds the new callback parameter. Actual implementation will come later in separate patches. BUG=128079 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193092

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -34 lines) Patch
M chrome/browser/google_apis/drive_api_operations.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations_unittest.cc View 5 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/google_apis/drive_api_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google_apis/drive_api_service.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_service_interface.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_uploader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google_apis/drive_uploader_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/dummy_drive_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google_apis/dummy_drive_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google_apis/fake_drive_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google_apis/fake_drive_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google_apis/fake_drive_service_unittest.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/google_apis/mock_drive_service.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
ptal
7 years, 8 months ago (2013-04-09 06:34:41 UTC) #1
hidehiko
On 2013/04/09 06:34:41, kinaba wrote: > ptal LGTM. Hope we won't conflict...
7 years, 8 months ago (2013-04-09 06:46:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/13927002/2021
7 years, 8 months ago (2013-04-09 07:52:10 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 14:05:37 UTC) #4
Message was sent while issue was closed.
Change committed as 193092

Powered by Google App Engine
This is Rietveld 408576698