Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: test/cctest/test-api.cc

Issue 139263008: Fix stub-invoked setter callback handling. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: Improved and simplified test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/stub-cache-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 21609 matching lines...) Expand 10 before | Expand all | Expand 10 after
21620 } 21620 }
21621 for (int i = 0; i < runs; i++) { 21621 for (int i = 0; i < runs; i++) {
21622 Local<String> expected; 21622 Local<String> expected;
21623 if (i != 0) { 21623 if (i != 0) {
21624 CHECK_EQ(v8_str("escape value"), values[i]); 21624 CHECK_EQ(v8_str("escape value"), values[i]);
21625 } else { 21625 } else {
21626 CHECK(values[i].IsEmpty()); 21626 CHECK(values[i].IsEmpty());
21627 } 21627 }
21628 } 21628 }
21629 } 21629 }
21630
21631
21632 static void SetterWhichExpectsThisAndHolderToDiffer(
21633 Local<String>, Local<Value>, const v8::PropertyCallbackInfo<void>& info) {
21634 CHECK(info.Holder() != info.This());
21635 }
21636
21637
21638 TEST(Regress239669) {
21639 LocalContext context;
21640 v8::Isolate* isolate = context->GetIsolate();
21641 v8::HandleScope scope(isolate);
21642 Local<ObjectTemplate> templ = ObjectTemplate::New(isolate);
21643 templ->SetAccessor(v8_str("x"), 0, SetterWhichExpectsThisAndHolderToDiffer);
21644 context->Global()->Set(v8_str("P"), templ->NewInstance());
21645 CompileRun(
21646 "function C1() {"
21647 " this.x = 23;"
21648 "};"
21649 "C1.prototype = P;"
21650 "for (var i = 0; i < 4; i++ ) {"
21651 " new C1();"
21652 "}");
21653 }
OLDNEW
« no previous file with comments | « src/x64/stub-cache-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698