Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 139263008: Fix stub-invoked setter callback handling. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: Improved and simplified test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/stub-cache.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2524 matching lines...) Expand 10 before | Expand all | Expand 10 after
2535 // Return the generated code. 2535 // Return the generated code.
2536 return GetCode(Code::NORMAL, name); 2536 return GetCode(Code::NORMAL, name);
2537 } 2537 }
2538 2538
2539 2539
2540 Handle<Code> StoreStubCompiler::CompileStoreCallback( 2540 Handle<Code> StoreStubCompiler::CompileStoreCallback(
2541 Handle<JSObject> object, 2541 Handle<JSObject> object,
2542 Handle<JSObject> holder, 2542 Handle<JSObject> holder,
2543 Handle<Name> name, 2543 Handle<Name> name,
2544 Handle<ExecutableAccessorInfo> callback) { 2544 Handle<ExecutableAccessorInfo> callback) {
2545 HandlerFrontend(IC::CurrentTypeOf(object, isolate()), 2545 Register holder_reg = HandlerFrontend(
2546 receiver(), holder, name); 2546 IC::CurrentTypeOf(object, isolate()), receiver(), holder, name);
2547 2547
2548 __ PopReturnAddressTo(scratch1()); 2548 __ PopReturnAddressTo(scratch1());
2549 __ push(receiver()); 2549 __ push(receiver());
2550 __ push(holder_reg);
2550 __ Push(callback); // callback info 2551 __ Push(callback); // callback info
2551 __ Push(name); 2552 __ Push(name);
2552 __ push(value()); 2553 __ push(value());
2553 __ PushReturnAddressFrom(scratch1()); 2554 __ PushReturnAddressFrom(scratch1());
2554 2555
2555 // Do tail-call to the runtime system. 2556 // Do tail-call to the runtime system.
2556 ExternalReference store_callback_property = 2557 ExternalReference store_callback_property =
2557 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate()); 2558 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate());
2558 __ TailCallExternalReference(store_callback_property, 4, 1); 2559 __ TailCallExternalReference(store_callback_property, 5, 1);
2559 2560
2560 // Return the generated code. 2561 // Return the generated code.
2561 return GetCode(kind(), Code::FAST, name); 2562 return GetCode(kind(), Code::FAST, name);
2562 } 2563 }
2563 2564
2564 2565
2565 Handle<Code> StoreStubCompiler::CompileStoreCallback( 2566 Handle<Code> StoreStubCompiler::CompileStoreCallback(
2566 Handle<JSObject> object, 2567 Handle<JSObject> object,
2567 Handle<JSObject> holder, 2568 Handle<JSObject> holder,
2568 Handle<Name> name, 2569 Handle<Name> name,
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
2906 // ----------------------------------- 2907 // -----------------------------------
2907 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 2908 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
2908 } 2909 }
2909 2910
2910 2911
2911 #undef __ 2912 #undef __
2912 2913
2913 } } // namespace v8::internal 2914 } } // namespace v8::internal
2914 2915
2915 #endif // V8_TARGET_ARCH_X64 2916 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/stub-cache.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698