Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: src/mips/stub-cache-mips.cc

Issue 139263008: Fix stub-invoked setter callback handling. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: Improved and simplified test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2496 matching lines...) Expand 10 before | Expand all | Expand 10 after
2507 // Return the generated code. 2507 // Return the generated code.
2508 return GetCode(Code::NORMAL, name); 2508 return GetCode(Code::NORMAL, name);
2509 } 2509 }
2510 2510
2511 2511
2512 Handle<Code> StoreStubCompiler::CompileStoreCallback( 2512 Handle<Code> StoreStubCompiler::CompileStoreCallback(
2513 Handle<JSObject> object, 2513 Handle<JSObject> object,
2514 Handle<JSObject> holder, 2514 Handle<JSObject> holder,
2515 Handle<Name> name, 2515 Handle<Name> name,
2516 Handle<ExecutableAccessorInfo> callback) { 2516 Handle<ExecutableAccessorInfo> callback) {
2517 HandlerFrontend(IC::CurrentTypeOf(object, isolate()), 2517 Register holder_reg = HandlerFrontend(
2518 receiver(), holder, name); 2518 IC::CurrentTypeOf(object, isolate()), receiver(), holder, name);
2519 2519
2520 // Stub never generated for non-global objects that require access 2520 // Stub never generated for non-global objects that require access
2521 // checks. 2521 // checks.
2522 ASSERT(holder->IsJSGlobalProxy() || !holder->IsAccessCheckNeeded()); 2522 ASSERT(holder->IsJSGlobalProxy() || !holder->IsAccessCheckNeeded());
2523 2523
2524 __ push(receiver()); // Receiver. 2524 __ push(receiver()); // Receiver.
2525 __ push(holder_reg);
2525 __ li(at, Operand(callback)); // Callback info. 2526 __ li(at, Operand(callback)); // Callback info.
2526 __ push(at); 2527 __ push(at);
2527 __ li(at, Operand(name)); 2528 __ li(at, Operand(name));
2528 __ Push(at, value()); 2529 __ Push(at, value());
2529 2530
2530 // Do tail-call to the runtime system. 2531 // Do tail-call to the runtime system.
2531 ExternalReference store_callback_property = 2532 ExternalReference store_callback_property =
2532 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate()); 2533 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate());
2533 __ TailCallExternalReference(store_callback_property, 4, 1); 2534 __ TailCallExternalReference(store_callback_property, 5, 1);
2534 2535
2535 // Return the generated code. 2536 // Return the generated code.
2536 return GetCode(kind(), Code::FAST, name); 2537 return GetCode(kind(), Code::FAST, name);
2537 } 2538 }
2538 2539
2539 2540
2540 Handle<Code> StoreStubCompiler::CompileStoreCallback( 2541 Handle<Code> StoreStubCompiler::CompileStoreCallback(
2541 Handle<JSObject> object, 2542 Handle<JSObject> object,
2542 Handle<JSObject> holder, 2543 Handle<JSObject> holder,
2543 Handle<Name> name, 2544 Handle<Name> name,
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
2884 // ----------------------------------- 2885 // -----------------------------------
2885 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 2886 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
2886 } 2887 }
2887 2888
2888 2889
2889 #undef __ 2890 #undef __
2890 2891
2891 } } // namespace v8::internal 2892 } } // namespace v8::internal
2892 2893
2893 #endif // V8_TARGET_ARCH_MIPS 2894 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698