Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 139263008: Fix stub-invoked setter callback handling. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: Improved and simplified test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2620 matching lines...) Expand 10 before | Expand all | Expand 10 after
2631 // Return the generated code. 2631 // Return the generated code.
2632 return GetCode(Code::NORMAL, name); 2632 return GetCode(Code::NORMAL, name);
2633 } 2633 }
2634 2634
2635 2635
2636 Handle<Code> StoreStubCompiler::CompileStoreCallback( 2636 Handle<Code> StoreStubCompiler::CompileStoreCallback(
2637 Handle<JSObject> object, 2637 Handle<JSObject> object,
2638 Handle<JSObject> holder, 2638 Handle<JSObject> holder,
2639 Handle<Name> name, 2639 Handle<Name> name,
2640 Handle<ExecutableAccessorInfo> callback) { 2640 Handle<ExecutableAccessorInfo> callback) {
2641 HandlerFrontend(IC::CurrentTypeOf(object, isolate()), 2641 Register holder_reg = HandlerFrontend(
2642 receiver(), holder, name); 2642 IC::CurrentTypeOf(object, isolate()), receiver(), holder, name);
2643 2643
2644 __ pop(scratch1()); // remove the return address 2644 __ pop(scratch1()); // remove the return address
2645 __ push(receiver()); 2645 __ push(receiver());
2646 __ push(holder_reg);
2646 __ Push(callback); 2647 __ Push(callback);
2647 __ Push(name); 2648 __ Push(name);
2648 __ push(value()); 2649 __ push(value());
2649 __ push(scratch1()); // restore return address 2650 __ push(scratch1()); // restore return address
2650 2651
2651 // Do tail-call to the runtime system. 2652 // Do tail-call to the runtime system.
2652 ExternalReference store_callback_property = 2653 ExternalReference store_callback_property =
2653 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate()); 2654 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate());
2654 __ TailCallExternalReference(store_callback_property, 4, 1); 2655 __ TailCallExternalReference(store_callback_property, 5, 1);
2655 2656
2656 // Return the generated code. 2657 // Return the generated code.
2657 return GetCode(kind(), Code::FAST, name); 2658 return GetCode(kind(), Code::FAST, name);
2658 } 2659 }
2659 2660
2660 2661
2661 Handle<Code> StoreStubCompiler::CompileStoreCallback( 2662 Handle<Code> StoreStubCompiler::CompileStoreCallback(
2662 Handle<JSObject> object, 2663 Handle<JSObject> object,
2663 Handle<JSObject> holder, 2664 Handle<JSObject> holder,
2664 Handle<Name> name, 2665 Handle<Name> name,
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
2992 // ----------------------------------- 2993 // -----------------------------------
2993 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 2994 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
2994 } 2995 }
2995 2996
2996 2997
2997 #undef __ 2998 #undef __
2998 2999
2999 } } // namespace v8::internal 3000 } } // namespace v8::internal
3000 3001
3001 #endif // V8_TARGET_ARCH_IA32 3002 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698