Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 139263008: Fix stub-invoked setter callback handling. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: Improved and simplified test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2500 matching lines...) Expand 10 before | Expand all | Expand 10 after
2511 // Return the generated code. 2511 // Return the generated code.
2512 return GetCode(Code::NORMAL, name); 2512 return GetCode(Code::NORMAL, name);
2513 } 2513 }
2514 2514
2515 2515
2516 Handle<Code> StoreStubCompiler::CompileStoreCallback( 2516 Handle<Code> StoreStubCompiler::CompileStoreCallback(
2517 Handle<JSObject> object, 2517 Handle<JSObject> object,
2518 Handle<JSObject> holder, 2518 Handle<JSObject> holder,
2519 Handle<Name> name, 2519 Handle<Name> name,
2520 Handle<ExecutableAccessorInfo> callback) { 2520 Handle<ExecutableAccessorInfo> callback) {
2521 HandlerFrontend(IC::CurrentTypeOf(object, isolate()), 2521 Register holder_reg = HandlerFrontend(
2522 receiver(), holder, name); 2522 IC::CurrentTypeOf(object, isolate()), receiver(), holder, name);
2523 2523
2524 // Stub never generated for non-global objects that require access checks. 2524 // Stub never generated for non-global objects that require access checks.
2525 ASSERT(holder->IsJSGlobalProxy() || !holder->IsAccessCheckNeeded()); 2525 ASSERT(holder->IsJSGlobalProxy() || !holder->IsAccessCheckNeeded());
2526 2526
2527 __ push(receiver()); // receiver 2527 __ push(receiver()); // receiver
2528 __ push(holder_reg);
2528 __ mov(ip, Operand(callback)); // callback info 2529 __ mov(ip, Operand(callback)); // callback info
2529 __ push(ip); 2530 __ push(ip);
2530 __ mov(ip, Operand(name)); 2531 __ mov(ip, Operand(name));
2531 __ Push(ip, value()); 2532 __ Push(ip, value());
2532 2533
2533 // Do tail-call to the runtime system. 2534 // Do tail-call to the runtime system.
2534 ExternalReference store_callback_property = 2535 ExternalReference store_callback_property =
2535 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate()); 2536 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate());
2536 __ TailCallExternalReference(store_callback_property, 4, 1); 2537 __ TailCallExternalReference(store_callback_property, 5, 1);
2537 2538
2538 // Return the generated code. 2539 // Return the generated code.
2539 return GetCode(kind(), Code::FAST, name); 2540 return GetCode(kind(), Code::FAST, name);
2540 } 2541 }
2541 2542
2542 2543
2543 Handle<Code> StoreStubCompiler::CompileStoreCallback( 2544 Handle<Code> StoreStubCompiler::CompileStoreCallback(
2544 Handle<JSObject> object, 2545 Handle<JSObject> object,
2545 Handle<JSObject> holder, 2546 Handle<JSObject> holder,
2546 Handle<Name> name, 2547 Handle<Name> name,
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
2890 // ----------------------------------- 2891 // -----------------------------------
2891 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 2892 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
2892 } 2893 }
2893 2894
2894 2895
2895 #undef __ 2896 #undef __
2896 2897
2897 } } // namespace v8::internal 2898 } } // namespace v8::internal
2898 2899
2899 #endif // V8_TARGET_ARCH_ARM 2900 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698