Add a GYP flag to enable coverage gathering instrumentation in ASan builds.

Add a GYP flag to enable coverage gathering instrumentation in ASan builds.

BUG=324216
R=glider@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245091

[earthdok, 2014-01-15 15:25:23]

ptal

[Alexander Potapenko, 2014-01-15 16:35:00]

https://codereview.chromium.org/139263003/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/139263003/diff/1/build/common.gypi#newcode938
build/common.gypi:938: 'asan_coverage%': '<(asan_coverage)',
Can we have asan_coverage=1 imply asan=1?

https://codereview.chromium.org/139263003/diff/1/build/common.gypi#newcode4137
build/common.gypi:4137: '-mllvm -asan-coverage=1',
What about the xcode-specific flags?

[Alexander Potapenko, 2014-01-15 16:36:58]

On 2014/01/15 16:35:00, Alexander Potapenko wrote:
> https://codereview.chromium.org/139263003/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
> https://codereview.chromium.org/139263003/diff/1/build/common.gypi#newcode938
> build/common.gypi:938: 'asan_coverage%': '<(asan_coverage)',
> Can we have asan_coverage=1 imply asan=1?
Or just put that under asan=1 clause.
 
> https://codereview.chromium.org/139263003/diff/1/build/common.gypi#newcode4137
> build/common.gypi:4137: '-mllvm -asan-coverage=1',
> What about the xcode-specific flags?
Ah, here they are.

[Alexander Potapenko, 2014-01-15 16:39:23]

On 2014/01/15 16:36:58, Alexander Potapenko wrote:
> On 2014/01/15 16:35:00, Alexander Potapenko wrote:
> > https://codereview.chromium.org/139263003/diff/1/build/common.gypi
> > File build/common.gypi (right):
> > 
> >
https://codereview.chromium.org/139263003/diff/1/build/common.gypi#newcode938
> > build/common.gypi:938: 'asan_coverage%': '<(asan_coverage)',
> > Can we have asan_coverage=1 imply asan=1?
> Or just put that under asan=1 clause.

LGTM for now, feel free to do that separately.

[commit-bot: I haz the power, 2014-01-15 17:00:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/earthdok@chromium.org/139263003/1

[commit-bot: I haz the power, 2014-01-16 03:25:04]

Change committed as 245091