Issue 13926016: Remove unneeded headers from ScriptExecutionContext.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13926016: Remove unneeded headers from ScriptExecutionContext.h (Closed)

Created:
7 years, 8 months ago by Nico

Modified:
7 years, 8 months ago

Reviewers:
abarth-chromium, eseidel

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Remove unneeded headers from ScriptExecutionContext.h Merges http://trac.webkit.org/changeset/148536 by AwfulUndersea (but doesn't add includes of wtf/StackStats.h all over the place). With https://codereview.chromium.org/14323004/ , https://codereview.chromium.org/13976008/ and this: Full builds of DumpRenderTree take ~24min instead of ~26 min (best-of-two each) on my laptop – ~10% faster. After `touch third_party/WebKit/Source/bindings/v8/ScriptState.h`, a rebuild of DumpRenderTree now reruns 875 build steps instead of 2077 and needs 9m20s instead of 16m49s previously. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148613

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	Source/WebCore/dom/ScriptExecutionContext.h	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
	M	Source/WebCore/dom/ScriptExecutionContext.cpp	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

Nico

Committed patchset #2 manually as r148613 (presubmit successful).

7 years, 8 months ago (2013-04-18 04:29:59 UTC) #3

Message was sent while issue was closed.

I LOVE IT.  Keep em' coming!

Thank you!