Issue 13926013: Fix P2PSocketHostTcp to handle async write correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13926013: Fix P2PSocketHostTcp to handle async write correctly. (Closed)

Created:
7 years, 8 months ago by Sergey Ulanov

Modified:
7 years, 8 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix P2PSocketHostTcp to handle async write correctly. Previously P2PSocketHostTcp was calling Write() even when another write is pending. BUG=232046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194628

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -5 lines)			Patch
M	content/browser/renderer_host/p2p/socket_host_tcp.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_tcp.cc	View	4 chunks	+8 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_test_utils.h	View	6 chunks	+36 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Alpha Left Google

LGTM. Does P2PSocketHostTcpServer has the same problem?

7 years, 8 months ago (2013-04-17 02:06:27 UTC) #2

Sergey Ulanov

On 2013/04/17 02:06:27, Alpha wrote: > LGTM. > > Does P2PSocketHostTcpServer has the same problem? ...

7 years, 8 months ago (2013-04-17 05:09:09 UTC) #3

Sergey Ulanov

7 years, 8 months ago (2013-04-17 17:50:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r194628 (presubmit successful).