ui/app_list: Remove unnecessary scoped_ptr ".get()" calls.

ui/app_list: Remove unnecessary scoped_ptr ".get()" calls.

This patch was generated by Elliot's script:

$ cd ui/app_list
$ git ls-files | xargs sed -i -e "s/if (\(.*\)\.get())/if (\1)/g;"

BUG=232084
R=xiyuan@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194885

[tfarina, 2013-04-16 22:16:27]

Hi Xiyuan, could you review this to me?

Thanks,

[Elliot Glaysher, 2013-04-16 22:17:56]

On 2013/04/16 22:16:27, tfarina wrote:
> Hi Xiyuan, could you review this to me?
> 
> Thanks,

You should try to compile it, at least locally first. That script has lots of
false positives. (Especially in GTK and Mac code)

[tfarina, 2013-04-16 22:19:23]

On Tue, Apr 16, 2013 at 7:17 PM, <erg@chromium.org> wrote:

> On 2013/04/16 22:16:27, tfarina wrote:
>
>> Hi Xiyuan, could you review this to me?
>>
>
>  Thanks,
>>
>
> You should try to compile it, at least locally first. That script has lots
> of
> false positives. (Especially in GTK and Mac code)
>
> I'll, is just it takes more than 1 hour here :)

-- 
Thiago

[xiyuan, 2013-04-16 22:37:20]

https://codereview.chromium.org/13926010/diff/1/ui/app_list/cocoa/apps_grid_v...
File ui/app_list/cocoa/apps_grid_view_item.mm (right):

https://codereview.chromium.org/13926010/diff/1/ui/app_list/cocoa/apps_grid_v...
ui/app_list/cocoa/apps_grid_view_item.mm:182: if (trackingArea_)
This is probably does not compile. |trackingArea_| is ScopedCrTrackingArea.

https://codereview.chromium.org/13926010/diff/1/ui/app_list/views/search_resu...
File ui/app_list/views/search_result_view.cc (right):

https://codereview.chromium.org/13926010/diff/1/ui/app_list/views/search_resu...
ui/app_list/views/search_result_view.cc:206: if (title_text_.get() &&
details_text_) {
title_text_.get() could be changed too.

[tfarina, 2013-04-16 23:15:48]

Built!

Please, could you take another look at patch set 2?

Thanks!

https://codereview.chromium.org/13926010/diff/1/ui/app_list/cocoa/apps_grid_v...
File ui/app_list/cocoa/apps_grid_view_item.mm (right):

https://codereview.chromium.org/13926010/diff/1/ui/app_list/cocoa/apps_grid_v...
ui/app_list/cocoa/apps_grid_view_item.mm:182: if (trackingArea_)
On 2013/04/16 22:37:20, xiyuan wrote:
> This is probably does not compile. |trackingArea_| is ScopedCrTrackingArea.
backed out.

https://codereview.chromium.org/13926010/diff/1/ui/app_list/views/search_resu...
File ui/app_list/views/search_result_view.cc (right):

https://codereview.chromium.org/13926010/diff/1/ui/app_list/views/search_resu...
ui/app_list/views/search_result_view.cc:206: if (title_text_.get() &&
details_text_) {
On 2013/04/16 22:37:20, xiyuan wrote:
> title_text_.get() could be changed too.

Done.

[xiyuan, 2013-04-16 23:21:05]

lgtm

[tfarina, 2013-04-18 11:38:59]

Committed patchset #2 manually as r194885 (presubmit successful).