Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 13926008: Don't shrink starting_rect in the first round. (Closed)

Created:
7 years, 8 months ago by Xianzhu
Modified:
7 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Don't shrink starting_rect in the first round. Sometimes a target_area smaller than the viewport (starting_rect) is passed to ExpandRectEquallyToAreaBoundedBy(). If we shrink the starting_rect to the target_area before considering the bounds, a bound in the viewport but at the edge of viewport will be excluded from prioritization. In the first round only expand but not shrink starting_rect. BUG=231370 TEST=PictureLayerTilingSet.ShrinkRectContainingBounds

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M cc/resources/picture_layer_tiling.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Xianzhu
This may be related to https://codereview.chromium.org/13895005/ but perhaps resolves different issues.
7 years, 8 months ago (2013-04-16 21:50:09 UTC) #1
danakj
What do you think of this compared to https://codereview.chromium.org/13895005/ ?
7 years, 8 months ago (2013-04-16 21:53:04 UTC) #2
enne (OOO)
Punting review of this to Dana.
7 years, 8 months ago (2013-04-16 21:54:11 UTC) #3
Xianzhu
On 2013/04/16 21:53:04, danakj wrote: > What do you think of this compared to https://codereview.chromium.org/13895005/ ...
7 years, 8 months ago (2013-04-16 22:12:08 UTC) #4
Xianzhu
I'm sure this one is covered by 13895005. Abandoned.
7 years, 8 months ago (2013-04-16 22:44:50 UTC) #5
Xianzhu
7 years, 8 months ago (2013-04-17 00:14:38 UTC) #6
On 2013/04/16 22:44:50, Xianzhu wrote:
> I'm sure this one is covered by 13895005. Abandoned.

Reopened as we need a simple safe fix to be merged into m27. Consider this CL as
a candidate.

Powered by Google App Engine
This is Rietveld 408576698