Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 13925021: Remove 'friend SkRefCnt' from SkData. (Closed)

Created:
7 years, 8 months ago by bungeman-skia
Modified:
7 years, 8 months ago
Reviewers:
reed, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove 'friend SkRefCnt' from SkData.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -35 lines) Patch
M include/core/SkData.h View 1 chunk +2 lines, -33 lines 0 comments Download
M include/core/SkRefCnt.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
So the issue we were having (which motivated the 'friend') is that if a non-POD ...
7 years, 8 months ago (2013-04-15 22:34:25 UTC) #1
reed1
lgtm
7 years, 8 months ago (2013-04-16 11:49:23 UTC) #2
bungeman-skia
7 years, 8 months ago (2013-04-16 15:49:50 UTC) #3
Message was sent while issue was closed.
Committed revision 8697.

Powered by Google App Engine
This is Rietveld 408576698