Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc

Issue 13925019: fix GridLayout::CreatePanel for new style dialogs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: msw review Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
diff --git a/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc b/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
index 305e9589076ed654885c273e479463982f25750f..85398cda7a4d91b9c7c114874867a4da57e2500d 100644
--- a/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
+++ b/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
@@ -101,9 +101,8 @@ void MediaGalleriesDialogViews::InitChildViews() {
contents_->RemoveAllChildViews(true);
int dialog_content_width = views::Widget::GetLocalizedContentsWidth(
IDS_MEDIA_GALLERIES_DIALOG_CONTENT_WIDTH_CHARS);
- views::GridLayout* layout = new views::GridLayout(contents_);
- layout->SetInsets(views::kPanelVertMargin, views::kPanelHorizMargin,
- 0, views::kPanelHorizMargin);
+ views::GridLayout* layout = views::GridLayout::CreatePanel(contents_);
+ contents_->SetLayoutManager(layout);
int column_set_id = 0;
views::ColumnSet* columns = layout->AddColumnSet(column_set_id);
@@ -113,20 +112,16 @@ void MediaGalleriesDialogViews::InitChildViews() {
views::GridLayout::FIXED,
dialog_content_width,
0);
- contents_->SetLayoutManager(layout);
- contents_->set_border(views::Border::CreateEmptyBorder(
- views::kPanelSubVerticalSpacing,
- 0,
- views::kPanelSubVerticalSpacing,
- 0));
- // Header text.
- views::Label* header = new views::Label(controller_->GetHeader());
- ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
- header->SetFont(rb.GetFont(ui::ResourceBundle::MediumFont));
- header->SetHorizontalAlignment(gfx::ALIGN_LEFT);
- layout->StartRow(0, column_set_id);
- layout->AddView(header);
+ if (!DialogDelegate::UseNewStyle()) {
+ // Header text.
+ views::Label* header = new views::Label(controller_->GetHeader());
+ ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
+ header->SetFont(rb.GetFont(ui::ResourceBundle::MediumFont));
+ header->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+ layout->StartRow(0, column_set_id);
+ layout->AddView(header);
+ }
// Message text.
views::Label* subtext = new views::Label(controller_->GetSubtext());
@@ -311,7 +306,7 @@ string16 MediaGalleriesDialogViews::GetWindowTitle() const {
}
bool MediaGalleriesDialogViews::ShouldShowWindowTitle() const {
- return false;
+ return DialogDelegate::UseNewStyle();
}
void MediaGalleriesDialogViews::DeleteDelegate() {

Powered by Google App Engine
This is Rietveld 408576698