fix GridLayout::CreatePanel for new style dialogs

chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 184 matching lines @@
 bool ExtensionUninstallDialogDelegateView::Cancel() {
   if (dialog_)
     dialog_->ExtensionUninstallCanceled();
   return true;
 }
 
 string16 ExtensionUninstallDialogDelegateView::GetWindowTitle() const {
   return l10n_util::GetStringUTF16(IDS_EXTENSION_UNINSTALL_PROMPT_TITLE);
 }
 
-
 gfx::Size ExtensionUninstallDialogDelegateView::GetPreferredSize() {
   int width = kRightColumnWidth;
   width += kIconSize;
   width += views::kPanelHorizMargin * 3;

[msw, 2013/04/16 01:58:24]

Shouldn't this depend on DialogDelegate::UseNewStyle() like below?

[Evan Stade, 2013/04/16 19:58:25]

Done.

 
   int height = views::kPanelVertMargin * 2;
   height += heading_->GetHeightForWidth(kRightColumnWidth);
 
   return gfx::Size(width,
                    std::max(height, kIconSize + views::kPanelVertMargin * 2));
 }
 
 void ExtensionUninstallDialogDelegateView::Layout() {
-  int x = views::kPanelHorizMargin;
+  int x = DialogDelegate::UseNewStyle() ? views::kButtonHEdgeMarginNew :
+                                          views::kPanelHorizMargin;
   int y = views::kPanelVertMargin;
 
   heading_->SizeToFit(kRightColumnWidth);
 
   if (heading_->height() <= kIconSize) {
     icon_->SetBounds(x, y, kIconSize, kIconSize);
     x += kIconSize;
     x += views::kPanelHorizMargin;

[msw, 2013/04/16 01:58:24]

Should this optionally use views::kButtonHEdgeMarginNew?

[Evan Stade, 2013/04/16 19:58:25]

actually it should use a different constant (fixed)

 
     heading_->SetX(x);
     heading_->SetY(y + (kIconSize - heading_->height()) / 2);
   } else {
     icon_->SetBounds(x,
                      y + (heading_->height() - kIconSize) / 2,
                      kIconSize,
                      kIconSize);
     x += kIconSize;
     x += views::kPanelHorizMargin;

[msw, 2013/04/16 01:58:24]

Should this optionally use views::kButtonHEdgeMarginNew?

[Evan Stade, 2013/04/16 19:58:25]

ditto

 
     heading_->SetX(x);
     heading_->SetY(y);
   }
 }
 
 }  // namespace
 
 // static
 ExtensionUninstallDialog* ExtensionUninstallDialog::Create(
     Profile* profile,
     Browser* browser,
     Delegate* delegate) {
   return new ExtensionUninstallDialogViews(profile, browser, delegate);
 }