fix GridLayout::CreatePanel for new style dialogs

chrome/browser/ui/views/confirm_bubble_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/confirm_bubble_views.h"
 
 #include "chrome/browser/ui/confirm_bubble.h"
 #include "chrome/browser/ui/confirm_bubble_model.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/link.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/layout/layout_constants.h"
 #include "ui/views/widget/widget.h"
 
 ConfirmBubbleViews::ConfirmBubbleViews(ConfirmBubbleModel* model)
     : model_(model),
       link_(NULL) {
-  views::GridLayout* layout = new views::GridLayout(this);
-  // TODO(msw): Use layout constants and fix the new-style sizing.
-  layout->SetInsets(UseNewStyle() ? gfx::Insets(0, 0, 40, 0) :
-      gfx::Insets(views::kUnrelatedControlVerticalSpacing,
-                  views::kUnrelatedControlHorizontalSpacing,
-                  views::kUnrelatedControlVerticalSpacing,
-                  views::kUnrelatedControlHorizontalSpacing));
+  views::GridLayout* layout = views::GridLayout::CreatePanel(this);

[Evan Stade, 2013/04/16 01:39:39]

this is a behavioral change, but I think it's an improvement.

[msw, 2013/04/16 01:58:24]

A screenshot would help :)

[Evan Stade, 2013/04/16 19:58:25]

Done.

   SetLayoutManager(layout);
 
   // Use a fixed maximum message width, so longer messages will wrap.
   const int kMaxMessageWidth = 400;
   views::ColumnSet* cs = layout->AddColumnSet(0);
   cs->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER, 0,
                 views::GridLayout::FIXED, kMaxMessageWidth, false);
 
   // Add the message label.
   views::Label* label = new views::Label(model_->GetMessageText());
@@ skipping 70 matching lines @@
 namespace chrome {
 
 void ShowConfirmBubble(gfx::NativeView view,
                        const gfx::Point& origin,
                        ConfirmBubbleModel* model) {
   views::DialogDelegateView::CreateDialogWidget(
       new ConfirmBubbleViews(model), NULL, view)->Show();
 }
 
 }  // namespace chrome