Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 13925005: [chromedriver] Fix Android test runner by creating a new driver when needed. (Closed)

Created:
7 years, 8 months ago by kkania
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[chromedriver] Fix Android test runner by creating a new driver when needed. Also, change android_package to androidPackage, to match convention. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M patch.diff View 2 chunks +35 lines, -21 lines 0 comments Download
M test-nodeps-srcs.jar View Binary file 0 comments Download
M test-standalone.jar View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
kkania
7 years, 8 months ago (2013-04-10 17:04:07 UTC) #1
chrisgao (Use stgao instead)
lgtm As "android_package" is changed to "androidPackage", change on chromedriver side might be also required.
7 years, 8 months ago (2013-04-10 17:20:01 UTC) #2
kkania
7 years, 8 months ago (2013-04-10 17:21:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r193405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698