StringImpl should not be referred from StringImplCF.

Source/wtf/text/AtomicString.h

 /*
  * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 130 matching lines @@
     static AtomicString number(long long);
     static AtomicString number(unsigned long long);
 
     static AtomicString number(double, unsigned precision = 6, TrailingZerosTruncatingPolicy = TruncateTrailingZeros);
 
     bool isNull() const { return m_string.isNull(); }
     bool isEmpty() const { return m_string.isEmpty(); }
 
     static void remove(StringImpl*);
 
-#if USE(CF)
-    AtomicString(CFStringRef s) :  m_string(add(s)) { }
-#endif
-#ifdef __OBJC__
-    AtomicString(NSString* s) : m_string(add((CFStringRef)s)) { }
-    operator NSString*() const { return m_string; }
-#endif

[Nico, 2014/01/15 19:06:12]

The implementation in AtomicString.cpp is still around though?

[tasak, 2014/01/17 08:17:29]

I see. I removed AtomicStringCF.cpp (i.e. AtomicString::add(CFStringRef)).

     // AtomicString::fromUTF8 will return a null string if
     // the input data contains invalid UTF-8 sequences.
     static AtomicString fromUTF8(const char*, size_t);
     static AtomicString fromUTF8(const char*);
 
     CString ascii() const { return m_string.ascii(); }
     CString latin1() const { return m_string.latin1(); }
     CString utf8(UTF8ConversionMode mode = LenientUTF8Conversion) const { return m_string.utf8(mode); }
 
 #ifndef NDEBUG
@@ skipping 94 matching lines @@
 using WTF::nullAtom;
 using WTF::emptyAtom;
 using WTF::starAtom;
 using WTF::xmlAtom;
 using WTF::xmlnsAtom;
 using WTF::xlinkAtom;
 #endif
 
 #include "wtf/text/StringConcatenate.h"
 #endif // AtomicString_h