src/IceInstX86Base.h - Issue 1392383003: Subzero: Consider all instruction variables for register preference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX86Base.h

Issue 1392383003: Subzero: Consider all instruction variables for register preference. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstX86Base.h

diff --git a/src/IceInstX86Base.h b/src/IceInstX86Base.h

index 36b34ac9e22dce3d476c5cd7d9076680e2f5c20a..f93ac2bbcb1c82b29de409a42299185a8473272c 100644

--- a/src/IceInstX86Base.h

+++ b/src/IceInstX86Base.h

@@ -977,7 +977,9 @@ public:

bool isRedundantAssign() const override {

return checkForRedundantAssign(this->getDest(), this->getSrc(0));

}

- bool isSimpleAssign() const override { return true; }

+ bool isVarAssign() const override {

+ return llvm::isa<Variable>(this->getSrc(0));

+ }

void dump(const Cfg *Func) const override {

if (!BuildDefs::dump())

return;

« no previous file with comments | « src/IceInstVarIter.h ('k') | src/IceRegAlloc.cpp » ('j') | no next file with comments »