src/IceInstARM32.h - Issue 1392383003: Subzero: Consider all instruction variables for register preference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstARM32.h

Issue 1392383003: Subzero: Consider all instruction variables for register preference. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstARM32.h

diff --git a/src/IceInstARM32.h b/src/IceInstARM32.h

index ffc3be878426281ed0ba29daa782925e8c6e67fa..60b24844a68ec113f1f809375482a5cc424e6158 100644

--- a/src/IceInstARM32.h

+++ b/src/IceInstARM32.h

@@ -1152,7 +1152,7 @@ public:

return !isMultiDest() && !isMultiSource() &&

checkForRedundantAssign(getDest(), getSrc(0));

}

- bool isSimpleAssign() const override { return true; }

+ bool isVarAssign() const override { return llvm::isa<Variable>(getSrc(0)); }

void emit(const Cfg *Func) const override;

void emitIAS(const Cfg *Func) const override;

void dump(const Cfg *Func) const override;

« no previous file with comments | « src/IceInst.cpp ('k') | src/IceInstVarIter.h » ('j') | no next file with comments »