Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1392383002: further refactoring: merge RestrictedRules into TypeRules (Closed)

Created:
5 years, 2 months ago by Jennifer Messerly
Modified:
5 years, 2 months ago
Reviewers:
vsm, Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -35 lines) Patch
M lib/src/checker/rules.dart View 1 2 3 chunks +8 lines, -31 lines 0 comments Download
M lib/src/compiler.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M lib/strong_mode.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 2 months ago (2015-10-08 23:11:23 UTC) #2
Leaf
lgtm
5 years, 2 months ago (2015-10-09 23:04:08 UTC) #3
Jennifer Messerly
5 years, 2 months ago (2015-10-10 17:37:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3e154e363b81365fcc6c4413fd094d043a37d532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698