[heap] Cleanup: Enforce coding style in FreeList and FreeListCategory

[heap] Cleanup: Enforce coding style in FreeList and FreeListCategory

Also update comments.

BUG=

Committed: https://crrev.com/10019c2b059af3c7ad2e75bf2046b324c8ae2562
Cr-Commit-Position: refs/heads/master@{#31301}

[Michael Lippautz, 2015-10-13 11:25:50]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2015-10-13 11:25:51]

PTAL. Only refactoring, and updating comments (also trimming repetitive ones).

[Hannes Payer (out of office), 2015-10-15 12:23:42]

LGTM, just nits.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (left):

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.cc#oldcode2240
src/heap/spaces.cc:2240: heap_(owner->heap()),
Why did you remove heap?

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1599
src/heap/spaces.h:1599: // Note: Concurrency safe.
thread-safe.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1633
src/heap/spaces.h:1633: static const int kVeryLongFreeList = 500;
Let's add a comment that describes that constant.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1667
src/heap/spaces.h:1667: // 1-31 words: Such small free areas are discarded for
efficiency reasons. They
We could call this category "too small". WDYT?

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1700
src/heap/spaces.h:1700: // Note: Concurrency safe.
thread-safe.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1703
src/heap/spaces.h:1703: // Place a node on the free list. The block of size
{size_in_bytes} starting
Adds

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1705
src/heap/spaces.h:1705: // bytes that have been lost due to internal
fragmentation by freeing the
...bytes that were not added to the free list, because they freed memory block
is too small.

[Michael Lippautz, 2015-10-15 12:31:34]

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (left):

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.cc#oldcode2240
src/heap/spaces.cc:2240: heap_(owner->heap()),
On 2015/10/15 12:23:42, Hannes Payer wrote:
> Why did you remove heap?

There was only 1 caller (Free -> CreateFillerObject) and it is available through
its owner anyways.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1599
src/heap/spaces.h:1599: // Note: Concurrency safe.
On 2015/10/15 12:23:42, Hannes Payer wrote:
> thread-safe.

Done.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1633
src/heap/spaces.h:1633: static const int kVeryLongFreeList = 500;
On 2015/10/15 12:23:42, Hannes Payer wrote:
> Let's add a comment that describes that constant.

Done.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1667
src/heap/spaces.h:1667: // 1-31 words: Such small free areas are discarded for
efficiency reasons. They
On 2015/10/15 12:23:42, Hannes Payer wrote:
> We could call this category "too small". WDYT?

Done.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1700
src/heap/spaces.h:1700: // Note: Concurrency safe.
On 2015/10/15 12:23:42, Hannes Payer wrote:
> thread-safe.

Done.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1703
src/heap/spaces.h:1703: // Place a node on the free list. The block of size
{size_in_bytes} starting
On 2015/10/15 12:23:42, Hannes Payer wrote:
> Adds

Done.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1705
src/heap/spaces.h:1705: // bytes that have been lost due to internal
fragmentation by freeing the
On 2015/10/15 12:23:42, Hannes Payer wrote:
> ...bytes that were not added to the free list, because they freed memory block
> is too small.

Done.

[Michael Lippautz, 2015-10-15 12:31:34]

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (left):

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.cc#oldcode2240
src/heap/spaces.cc:2240: heap_(owner->heap()),
On 2015/10/15 12:23:42, Hannes Payer wrote:
> Why did you remove heap?

There was only 1 caller (Free -> CreateFillerObject) and it is available through
its owner anyways.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1599
src/heap/spaces.h:1599: // Note: Concurrency safe.
On 2015/10/15 12:23:42, Hannes Payer wrote:
> thread-safe.

Done.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1633
src/heap/spaces.h:1633: static const int kVeryLongFreeList = 500;
On 2015/10/15 12:23:42, Hannes Payer wrote:
> Let's add a comment that describes that constant.

Done.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1667
src/heap/spaces.h:1667: // 1-31 words: Such small free areas are discarded for
efficiency reasons. They
On 2015/10/15 12:23:42, Hannes Payer wrote:
> We could call this category "too small". WDYT?

Done.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1700
src/heap/spaces.h:1700: // Note: Concurrency safe.
On 2015/10/15 12:23:42, Hannes Payer wrote:
> thread-safe.

Done.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1703
src/heap/spaces.h:1703: // Place a node on the free list. The block of size
{size_in_bytes} starting
On 2015/10/15 12:23:42, Hannes Payer wrote:
> Adds

Done.

https://codereview.chromium.org/1392343004/diff/1/src/heap/spaces.h#newcode1705
src/heap/spaces.h:1705: // bytes that have been lost due to internal
fragmentation by freeing the
On 2015/10/15 12:23:42, Hannes Payer wrote:
> ...bytes that were not added to the free list, because they freed memory block
> is too small.

Done.

[Michael Lippautz, 2015-10-15 12:32:18]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-10-15 12:32:18]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1392343004/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2015-10-15 12:32:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1392343004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1392343004/20001

[commit-bot: I haz the power, 2015-10-15 13:30:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-15 13:31:02]

Patchset 2 (id:??) landed as
https://crrev.com/10019c2b059af3c7ad2e75bf2046b324c8ae2562
Cr-Commit-Position: refs/heads/master@{#31301}