Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1392343003:
Update libudev URL. (Closed)
|
Created:
5 years, 2 months ago by bungeman-chromium Modified:
5 years, 2 months ago Reviewers:
Reilly Grant (use Gerrit) CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate libudev URL.
The old URL has been removed; the content moved to
http://www.freedesktop.org/software/systemd/man/libudev.html .
However, now that libudev has been absorbed by systemd, set the URL
to the less volatile systemd URL.
BUG=chromium:476190
Committed: https://crrev.com/2bbefb545d46f110b490d639442bb6fbf311cbf9
Cr-Commit-Position: refs/heads/master@{#353585}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address comments. #Messages
Total messages: 19 (8 generated)
The CQ bit was checked by bungeman@chromium.org to run a CQ dry run
bungeman@chromium.org changed reviewers: + reillyg@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392343003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1392343003/diff/1/third_party/libudev/README.... File third_party/libudev/README.chromium (right): https://codereview.chromium.org/1392343003/diff/1/third_party/libudev/README.... third_party/libudev/README.chromium:2: URL: http://www.freedesktop.org/software/systemd/man/libudev.html I suggest changing this URL to http://www.freedesktop.org/wiki/Software/systemd/ instead.
https://codereview.chromium.org/1392343003/diff/1/third_party/libudev/README.... File third_party/libudev/README.chromium (right): https://codereview.chromium.org/1392343003/diff/1/third_party/libudev/README.... third_party/libudev/README.chromium:2: URL: http://www.freedesktop.org/software/systemd/man/libudev.html On 2015/10/12 19:24:12, Reilly Grant wrote: > I suggest changing this URL to http://www.freedesktop.org/wiki/Software/systemd/ > instead. As much as doing so pains me, you're probably right. I was just updating this to point to the same content it used to point at.
The CQ bit was checked by bungeman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392343003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392343003/20001
lgtm
The CQ bit was unchecked by bungeman@chromium.org
The CQ bit was checked by bungeman@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bungeman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392343003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392343003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2bbefb545d46f110b490d639442bb6fbf311cbf9 Cr-Commit-Position: refs/heads/master@{#353585} |
