content/public/browser/browser_plugin_guest_delegate.cc - Issue 1392343002: Reduce the public method footprint of GuestViewBase and derived types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/browser_plugin_guest_delegate.cc

Issue 1392343002: Reduce the public method footprint of GuestViewBase and derived types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Reverted reordering in cc files. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/browser/browser_plugin_guest_delegate.h ('k') | extensions/browser/api/guest_view/web_view/web_view_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/browser_plugin_guest_delegate.cc

diff --git a/content/public/browser/browser_plugin_guest_delegate.cc b/content/public/browser/browser_plugin_guest_delegate.cc

index fd7dec4ccf8ca1960eba28be12715a1cea6b694a..bfa19e4c074177f955f959c52d2abd773bc44ae9 100644

--- a/content/public/browser/browser_plugin_guest_delegate.cc

+++ b/content/public/browser/browser_plugin_guest_delegate.cc

@@ -20,13 +20,15 @@ WebContents* BrowserPluginGuestDelegate::GetOwnerWebContents() const {

return nullptr;

}

-bool BrowserPluginGuestDelegate::Find(int request_id,

- const base::string16& search_text,

- const blink::WebFindOptions& options) {

+bool BrowserPluginGuestDelegate::HandleFindForEmbedder(

+ int request_id,

+ const base::string16& search_text,

+ const blink::WebFindOptions& options) {

return false;

}

-bool BrowserPluginGuestDelegate::StopFinding(StopFindAction action) {

+bool BrowserPluginGuestDelegate::HandleStopFindingForEmbedder(

+ StopFindAction action) {

return false;

}