Reduce the public method footprint of GuestViewBase and derived types.

extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_MIME_HANDLER_VIEW_MIME_HANDLER_VIEW_GUEST_H_
 #define EXTENSIONS_BROWSER_GUEST_VIEW_MIME_HANDLER_VIEW_MIME_HANDLER_VIEW_GUEST_H_
 
 #include "base/memory/weak_ptr.h"
 #include "components/guest_view/browser/guest_view.h"
 
@@ skipping 39 matching lines @@
 };
 
 class MimeHandlerViewGuest :
     public guest_view::GuestView<MimeHandlerViewGuest> {
  public:
   static guest_view::GuestViewBase* Create(
       content::WebContents* owner_web_contents);
 
   static const char Type[];
 
-  // GuestViewBase implementation.
-  const char* GetAPINamespace() const override;
-  int GetTaskPrefix() const override;
-  void CreateWebContents(const base::DictionaryValue& create_params,
-                         const WebContentsCreatedCallback& callback) override;
-  void DidAttachToEmbedder() override;
-  void DidInitialize(const base::DictionaryValue& create_params) override;
-  bool ShouldHandleFindRequestsForEmbedder() const override;
-  bool ZoomPropagatesFromEmbedderToGuest() const override;
-
-  // WebContentsDelegate implementation.
-  content::WebContents* OpenURLFromTab(
-      content::WebContents* source,
-      const content::OpenURLParams& params) override;
-  bool HandleContextMenu(const content::ContextMenuParams& params) override;
-  bool PreHandleGestureEvent(content::WebContents* source,
-                             const blink::WebGestureEvent& event) override;
-  content::JavaScriptDialogManager* GetJavaScriptDialogManager(
-      content::WebContents* source) override;
-  bool SaveFrame(const GURL& url, const content::Referrer& referrer) override;
-
-  // content::WebContentsObserver implementation.
-  void DocumentOnLoadCompletedInMainFrame() override;
-
-  std::string view_id() const { return view_id_; }
-  base::WeakPtr<StreamContainer> GetStream() const;
-
  protected:
   explicit MimeHandlerViewGuest(content::WebContents* owner_web_contents);
   ~MimeHandlerViewGuest() override;
 
+  // GuestViewBase implementation.
+  void CreateWebContents(const base::DictionaryValue& create_params,

[Fady Samuel, 2015/10/09 22:35:19]

Why are these protected and not private?

[paulmeyer, 2015/10/16 21:13:03]

Because they are overridden by TestMimeHandlerViewGuest.

[Fady Samuel, 2015/10/16 21:17:28]

Make TestMimeHandlerViewGuest a friend class instead and move to private.

[paulmeyer, 2015/10/21 19:45:12]

Done.

+                         const WebContentsCreatedCallback& callback) override;
+  void DidAttachToEmbedder() override;
+
  private:
+  // GuestViewBase implementation.
+  const char* GetAPINamespace() const final;
+  int GetTaskPrefix() const final;
+  void DidInitialize(const base::DictionaryValue& create_params) final;
+  bool ShouldHandleFindRequestsForEmbedder() const final;
+  bool ZoomPropagatesFromEmbedderToGuest() const final;
+
+  // WebContentsDelegate implementation.
+  content::WebContents* OpenURLFromTab(
+      content::WebContents* source,
+      const content::OpenURLParams& params) final;
+  bool HandleContextMenu(const content::ContextMenuParams& params) final;
+  bool PreHandleGestureEvent(content::WebContents* source,
+                             const blink::WebGestureEvent& event) final;
+  content::JavaScriptDialogManager* GetJavaScriptDialogManager(
+      content::WebContents* source) final;
+  bool SaveFrame(const GURL& url, const content::Referrer& referrer) final;
+
+  // content::WebContentsObserver implementation.
+  void DocumentOnLoadCompletedInMainFrame() final;
+
+  std::string view_id() const { return view_id_; }
+  base::WeakPtr<StreamContainer> GetStream() const;
+
   scoped_ptr<MimeHandlerViewGuestDelegate> delegate_;
   scoped_ptr<StreamContainer> stream_;
   std::string view_id_;
 
   DISALLOW_COPY_AND_ASSIGN(MimeHandlerViewGuest);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_GUEST_VIEW_MIME_HANDLER_VIEW_MIME_HANDLER_VIEW_GUEST_H_