Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 139233004: Remove the HValueOf instruction. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer
Modified:
6 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -177 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +21 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Next one. PTAL
6 years, 10 months ago (2014-01-29 13:22:40 UTC) #1
Sven Panne
lgtm
6 years, 10 months ago (2014-01-29 13:32:42 UTC) #2
Benedikt Meurer
6 years, 10 months ago (2014-01-29 13:41:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18905 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698