cc/trees/layer_tree_host_common_unittest.cc - Issue 139233002: [#4] Pass gfx structs by const ref (gfx::PointF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_common_unittest.cc

Issue 139233002: [#4] Pass gfx structs by const ref (gfx::PointF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Corrected as per review comments! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_host_common_unittest.cc

diff --git a/cc/trees/layer_tree_host_common_unittest.cc b/cc/trees/layer_tree_host_common_unittest.cc

index 177342e4121263472842d07ea93ad0f2afaf642f..f7db3e1b55216a86ea47419b8c8bfff03f28a95a 100644

--- a/cc/trees/layer_tree_host_common_unittest.cc

+++ b/cc/trees/layer_tree_host_common_unittest.cc

@@ -42,8 +42,8 @@ class LayerTreeHostCommonTestBase {

LayerType* layer,

const gfx::Transform& transform,

const gfx::Transform& sublayer_transform,

- gfx::PointF anchor,

- gfx::PointF position,

+ const gfx::PointF& anchor,

+ const gfx::PointF& position,

gfx::Size bounds,

bool preserves3d) {

layer->SetTransform(transform);

@@ -57,8 +57,8 @@ class LayerTreeHostCommonTestBase {

void SetLayerPropertiesForTesting(Layer* layer,

const gfx::Transform& transform,

const gfx::Transform& sublayer_transform,

- gfx::PointF anchor,

- gfx::PointF position,

+ const gfx::PointF& anchor,

+ const gfx::PointF& position,

gfx::Size bounds,

bool preserves3d) {

SetLayerPropertiesForTestingInternal<Layer>(layer,

@@ -73,8 +73,8 @@ class LayerTreeHostCommonTestBase {

void SetLayerPropertiesForTesting(LayerImpl* layer,

const gfx::Transform& transform,

const gfx::Transform& sublayer_transform,

- gfx::PointF anchor,

- gfx::PointF position,

+ const gfx::PointF& anchor,

+ const gfx::PointF& position,

gfx::Size bounds,

bool preserves3d) {

SetLayerPropertiesForTestingInternal<LayerImpl>(layer,

« no previous file with comments | « cc/trees/layer_tree_host_common.cc ('k') | cc/trees/layer_tree_host_impl.h » ('j') | no next file with comments »