Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1392273002: Add correction message to bad linkage error. (Closed)

Created:
5 years, 2 months ago by Karl
Modified:
5 years, 2 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add correction message to bad linkage error. Adds message to use "-allow-externally-defined-symbols" on bad linkage errors. Also cleans up code by defining common reporting routine. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a313a121cc46b81bca7472e43ed0ae72156e8974

Patch Set 1 #

Patch Set 2 : Fix nit. #

Total comments: 2

Patch Set 3 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/PNaClTranslator.cpp View 1 2 2 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
5 years, 2 months ago (2015-10-08 17:30:42 UTC) #2
Jim Stichnoth
Thanks! LGTM https://chromiumcodereview.appspot.com/1392273002/diff/20001/src/PNaClTranslator.cpp File src/PNaClTranslator.cpp (right): https://chromiumcodereview.appspot.com/1392273002/diff/20001/src/PNaClTranslator.cpp#newcode483 src/PNaClTranslator.cpp:483: StrBuf << "\n Use flag -allow-externally-defined-symbols to ...
5 years, 2 months ago (2015-10-08 17:36:11 UTC) #3
Karl
Committed patchset #3 (id:40001) manually as a313a121cc46b81bca7472e43ed0ae72156e8974 (presubmit successful).
5 years, 2 months ago (2015-10-08 17:41:02 UTC) #4
Karl
5 years, 2 months ago (2015-10-08 17:41:14 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1392273002/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1392273002/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:483: StrBuf << "\n  Use flag
-allow-externally-defined-symbols to allow";
On 2015/10/08 17:36:11, stichnot wrote:
> maybe s/allow/override/ ?

Done.

Powered by Google App Engine
This is Rietveld 408576698