Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: mojo/devtools/common/devtoolslib/http_server.py

Issue 1392263003: mojo_run: make the port-in-use message helpful on Mac. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/http_server.py
diff --git a/mojo/devtools/common/devtoolslib/http_server.py b/mojo/devtools/common/devtoolslib/http_server.py
index 92aa8e65dfceedd2310e9f1b53a63af92d2428ee..2de71e1332663f1c0963d0f46b7518a7f94feadd 100644
--- a/mojo/devtools/common/devtoolslib/http_server.py
+++ b/mojo/devtools/common/devtoolslib/http_server.py
@@ -12,6 +12,7 @@ import math
import os.path
import socket
import subprocess
+import sys
import tempfile
import threading
@@ -237,8 +238,16 @@ def start_http_server(mappings, host_port=0):
print 'Failed to start http server for %s on port %d: %s.' % (
str(mappings), host_port, os.strerror(error_code))
if error_code == errno.EADDRINUSE:
- print (' Run `fuser %d/tcp` to find out which process is using the port;'
- % host_port)
- print (' or `fuser -k %d/tcp` terminate it.' % host_port)
+ if sys.platform == 'darwin':
+ find_cmd = 'lsof -i :%d' % host_port
+ terminate_cmd = (
+ 'lsof -i :%d | grep LISTEN | awk \'{print $2}\' | xargs kill -9'
+ % host_port)
+ else:
+ find_cmd = 'fuser %d/tcp' % host_port
+ terminate_cmd = 'fuser -k %d/tcp' % host_port
+ print (' Run `%s` to find out which process is using the port;'
+ % find_cmd)
+ print (' or `%s` terminate it.' % terminate_cmd)
print '---'
raise
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698