Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1392263003: mojo_run: make the port-in-use message helpful on Mac. (Closed)

Created:
5 years, 2 months ago by ppi
Modified:
5 years, 2 months ago
Reviewers:
tonyg
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

mojo_run: make the port-in-use message helpful on Mac. Fixes domokit/devtools#31. R=tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6658bb77764ef3ab7ca86002d7051d7aa982a973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M mojo/devtools/common/devtoolslib/http_server.py View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Tony, ptal.
5 years, 2 months ago (2015-10-12 21:53:57 UTC) #2
tonyg
lgtm
5 years, 2 months ago (2015-10-12 21:55:31 UTC) #3
ppi
5 years, 2 months ago (2015-10-12 21:58:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6658bb77764ef3ab7ca86002d7051d7aa982a973 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698