Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1392253002: Restructure the public API for server (Closed)

Created:
5 years, 2 months ago by Brian Wilkerson
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -1374 lines) Patch
D pkg/analysis_server/lib/analysis/analysis_domain.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D pkg/analysis_server/lib/analysis/index_core.dart View 1 chunk +0 lines, -280 lines 0 comments Download
D pkg/analysis_server/lib/analysis/navigation_core.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D pkg/analysis_server/lib/analysis/occurrences_core.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D pkg/analysis_server/lib/edit/assist/assist_core.dart View 1 chunk +0 lines, -99 lines 0 comments Download
D pkg/analysis_server/lib/edit/assist/assist_dart.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D pkg/analysis_server/lib/edit/fix/fix_core.dart View 1 chunk +0 lines, -103 lines 0 comments Download
D pkg/analysis_server/lib/edit/fix/fix_dart.dart View 1 chunk +0 lines, -46 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/analysis/analysis_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/plugin/analysis/analyzed_files.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/plugin/analysis/navigation/navigation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/analysis/navigation/navigation_core.dart View 3 chunks +15 lines, -15 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart View 1 chunk +13 lines, -13 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/analysis/resolver_provider.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/plugin/analyzed_files.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D pkg/analysis_server/lib/plugin/assist.dart View 1 chunk +0 lines, -37 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/edit/assist/assist.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/edit/assist/assist_core.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/edit/fix/fix.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/edit/fix/fix_core.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/edit/utilities/change_builder_core.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/edit/utilities/change_builder_dart.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/analysis_server/lib/plugin/fix.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/analysis_server/lib/plugin/index.dart View 1 chunk +0 lines, -43 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/index/index.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/index/index_core.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/plugin/navigation.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D pkg/analysis_server/lib/plugin/occurrences.dart View 1 chunk +0 lines, -39 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/occurrences.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 chunk +12 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/inherited_contributor.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/index_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/index_store.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/indexable_element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/local_index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/local_memory_index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/codec.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/split_store.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_dart.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/starter.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/uri/resolver_provider.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/analysis_server/lib/utilities/change_builder_core.dart View 1 chunk +0 lines, -123 lines 0 comments Download
D pkg/analysis_server/lib/utilities/change_builder_dart.dart View 1 chunk +0 lines, -156 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +2 lines, -2 lines 2 comments Download
M pkg/analysis_server/test/plugin/set_analysis_domain_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/store/codec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/store/split_store_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/utilities/change_builder_core_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Brian Wilkerson
Sorry about the size of the CL. There are no changes here other than moving ...
5 years, 2 months ago (2015-10-08 17:14:56 UTC) #2
scheglov
LGTM
5 years, 2 months ago (2015-10-08 17:23:25 UTC) #3
Paul Berry
lgtm with one minor nit. https://codereview.chromium.org/1392253002/diff/1/pkg/analysis_server/test/integration/integration_tests.dart File pkg/analysis_server/test/integration/integration_tests.dart (right): https://codereview.chromium.org/1392253002/diff/1/pkg/analysis_server/test/integration/integration_tests.dart#newcode633 pkg/analysis_server/test/integration/integration_tests.dart:633: // print('Launching $serverPath'); This ...
5 years, 2 months ago (2015-10-08 17:32:25 UTC) #4
danrubel
LGTM
5 years, 2 months ago (2015-10-08 18:09:15 UTC) #5
Brian Wilkerson
https://codereview.chromium.org/1392253002/diff/1/pkg/analysis_server/test/integration/integration_tests.dart File pkg/analysis_server/test/integration/integration_tests.dart (right): https://codereview.chromium.org/1392253002/diff/1/pkg/analysis_server/test/integration/integration_tests.dart#newcode633 pkg/analysis_server/test/integration/integration_tests.dart:633: // print('Launching $serverPath'); Done
5 years, 2 months ago (2015-10-09 14:56:44 UTC) #6
Brian Wilkerson
5 years, 2 months ago (2015-10-09 14:57:05 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8f4c63c92b5946e089691be657c5adf3fea7ad7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698