Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1392213003: Update URL for pyftpdlib. (Closed)

Created:
5 years, 2 months ago by bungeman-chromium
Modified:
5 years, 2 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
Paweł Hajdan Jr., asanka, benjhayden+dwatch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update URL for pyftpdlib. This project was hosted on Google Code, but has moved to github. BUG=chromium:476190 Committed: https://crrev.com/07d34009edc578b4b103da33606b60945cfcaae2 Cr-Commit-Position: refs/heads/master@{#353064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/pyftpdlib/README.chromium View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bungeman-chromium
In theory, I think the license file could be set to NOT_SHIPPED (like third_party/freetype2), since ...
5 years, 2 months ago (2015-10-08 15:01:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392213003/1
5 years, 2 months ago (2015-10-08 15:03:39 UTC) #4
Paweł Hajdan Jr.
LGTM
5 years, 2 months ago (2015-10-08 15:10:33 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 15:10:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392213003/1
5 years, 2 months ago (2015-10-08 15:43:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 15:49:29 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 15:50:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07d34009edc578b4b103da33606b60945cfcaae2
Cr-Commit-Position: refs/heads/master@{#353064}

Powered by Google App Engine
This is Rietveld 408576698