third_party/WebKit/Source/web/DevToolsEmulator.cpp - Issue 1392213002: Call setUseMobileViewportStyle before setViewportEnabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/DevToolsEmulator.cpp

Issue 1392213002: Call setUseMobileViewportStyle before setViewportEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/DevToolsEmulator.cpp

diff --git a/third_party/WebKit/Source/web/DevToolsEmulator.cpp b/third_party/WebKit/Source/web/DevToolsEmulator.cpp

index 8bef12c7ce117d21a4748963e000ac80dc035cca..d8b8840bc284e76b6441be08b937b72c4e7a3df4 100644

--- a/third_party/WebKit/Source/web/DevToolsEmulator.cpp

+++ b/third_party/WebKit/Source/web/DevToolsEmulator.cpp

@@ -237,13 +237,13 @@ void DevToolsEmulator::enableMobileEmulation()

m_emulateMobileEnabled = true;

m_isOverlayScrollbarsEnabled = RuntimeEnabledFeatures::overlayScrollbarsEnabled();

RuntimeEnabledFeatures::setOverlayScrollbarsEnabled(true);

+ m_webViewImpl->page()->settings().setUseMobileViewportStyle(true);

m_webViewImpl->enableViewport();

m_webViewImpl->settings()->setViewportMetaEnabled(true);

m_webViewImpl->page()->frameHost().visualViewport().initializeScrollbars();

m_webViewImpl->settings()->setShrinksViewportContentToFit(true);

m_webViewImpl->page()->settings().setTextAutosizingEnabled(true);

m_webViewImpl->page()->settings().setPreferCompositingToLCDTextEnabled(true);

- m_webViewImpl->page()->settings().setUseMobileViewportStyle(true);

m_webViewImpl->page()->settings().setPluginsEnabled(false);

m_webViewImpl->page()->settings().setAvailablePointerTypes(PointerTypeCoarse);

m_webViewImpl->page()->settings().setPrimaryPointerType(PointerTypeCoarse);

« content/browser/resource_loading_browsertest.cc ('K') | « content/test/data/resource_loading/resource_loading_non_mobile.html ('k') | no next file » | no next file with comments »