Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1392173005: [CT] Update worker scripts to use new benchmarks and delete old benchmarks (Closed)

Created:
5 years, 2 months ago by rmistry
Modified:
5 years, 2 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[CT] Update worker scripts to use new benchmarks and delete old benchmarks. This will work because of the new style of CT benchmarks created in https://codereview.chromium.org/1393023002/ (not landed yet). BUG=skia:4435 Committed: https://skia.googlesource.com/buildbot/+/137abbe65af6da74f61a530fc102b2cdf5e4693a

Patch Set 1 : Initial upload #

Patch Set 2 : Update run_chromium_perf #

Patch Set 3 : capture_skps #

Patch Set 4 : Fix for skpicture_printer #

Patch Set 5 : Remove staging code #

Total comments: 4

Patch Set 6 : Address comments #

Patch Set 7 : Cleanup capture_archives #

Total comments: 2

Patch Set 8 : Documentation #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -342 lines) Patch
M ct/go/util/constants.go View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -5 lines 0 comments Download
M ct/go/util/util.go View 1 2 3 4 5 6 7 2 chunks +23 lines, -0 lines 0 comments Download
M ct/go/worker_scripts/capture_archives/main.go View 1 2 3 4 5 6 2 chunks +11 lines, -7 lines 0 comments Download
M ct/go/worker_scripts/capture_skps/main.go View 1 2 3 4 5 2 chunks +11 lines, -10 lines 0 comments Download
M ct/go/worker_scripts/run_chromium_perf/main.go View 1 2 3 4 5 1 chunk +10 lines, -8 lines 0 comments Download
D ct/py/benchmarks/draw_properties.py View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
D ct/py/benchmarks/rasterize_and_record_micro.py View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
D ct/py/benchmarks/repaint.py View 1 2 1 chunk +0 lines, -56 lines 0 comments Download
D ct/py/benchmarks/skpicture_printer.py View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D ct/py/benchmarks/smoothness.py View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
M ct/py/create_page_set.py View 2 chunks +6 lines, -47 lines 0 comments Download
D ct/py/ct_run_benchmark View 1 2 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 26 (9 generated)
rmistry
5 years, 2 months ago (2015-10-14 17:38:07 UTC) #2
rmistry
5 years, 2 months ago (2015-10-14 17:38:09 UTC) #3
dogben
lgtm https://codereview.chromium.org/1392173005/diff/80001/ct/go/worker_scripts/capture_archives/main.go File ct/go/worker_scripts/capture_archives/main.go (right): https://codereview.chromium.org/1392173005/diff/80001/ct/go/worker_scripts/capture_archives/main.go#newcode102 ct/go/worker_scripts/capture_archives/main.go:102: pagesetContent, err := os.Open(pagesetPath) Nit: maybe create a ...
5 years, 2 months ago (2015-10-14 18:25:50 UTC) #4
rmistry
https://codereview.chromium.org/1392173005/diff/80001/ct/go/worker_scripts/capture_archives/main.go File ct/go/worker_scripts/capture_archives/main.go (right): https://codereview.chromium.org/1392173005/diff/80001/ct/go/worker_scripts/capture_archives/main.go#newcode102 ct/go/worker_scripts/capture_archives/main.go:102: pagesetContent, err := os.Open(pagesetPath) On 2015/10/14 18:25:50, Ben Wagner ...
5 years, 2 months ago (2015-10-15 12:23:21 UTC) #5
dogben
lgtm https://codereview.chromium.org/1392173005/diff/120001/ct/go/util/util.go File ct/go/util/util.go (right): https://codereview.chromium.org/1392173005/diff/120001/ct/go/util/util.go#newcode242 ct/go/util/util.go:242: type PagesetVars struct { Nit: documentation.
5 years, 2 months ago (2015-10-15 13:51:57 UTC) #6
rmistry
https://codereview.chromium.org/1392173005/diff/120001/ct/go/util/util.go File ct/go/util/util.go (right): https://codereview.chromium.org/1392173005/diff/120001/ct/go/util/util.go#newcode242 ct/go/util/util.go:242: type PagesetVars struct { On 2015/10/15 13:51:57, Ben Wagner ...
5 years, 2 months ago (2015-10-15 14:21:56 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392173005/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392173005/160001
5 years, 2 months ago (2015-10-15 14:22:10 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Infra-PerCommit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/1662)
5 years, 2 months ago (2015-10-15 14:23:02 UTC) #12
dogben
lgtm
5 years, 2 months ago (2015-10-15 14:28:42 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392173005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392173005/180001
5 years, 2 months ago (2015-10-15 15:02:26 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Infra-PerCommit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/1664)
5 years, 2 months ago (2015-10-15 15:04:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392173005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392173005/180001
5 years, 2 months ago (2015-10-15 17:05:38 UTC) #20
commit-bot: I haz the power
Committed patchset #9 (id:180001) as https://skia.googlesource.com/buildbot/+/137abbe65af6da74f61a530fc102b2cdf5e4693a
5 years, 2 months ago (2015-10-15 17:07:17 UTC) #21
commit-bot: I haz the power
No file was found in this patchset.
5 years, 2 months ago (2015-10-15 17:32:04 UTC) #23
commit-bot: I haz the power
No file was found in this patchset.
5 years, 2 months ago (2015-10-15 17:32:20 UTC) #24
tandrii(chromium)
On 2015/10/15 17:32:20, commit-bot: I haz the power wrote: > No file was found in ...
5 years, 2 months ago (2015-10-15 18:00:03 UTC) #25
rmistry
5 years, 2 months ago (2015-10-15 18:17:38 UTC) #26
Message was sent while issue was closed. 
On 2015/10/15 18:00:03, tandrii(chromium) wrote:
> On 2015/10/15 17:32:20, commit-bot: I haz the power wrote:
> > No file was found in this patchset.
> 
> So, here is what happened: CQ committed your patch, updated the description
and
> then crashed, thus the chebox was still checked (you can see that in generated
> messages). Then, CQ was auto-started, and discovered this CL again, tried to
> commit it, and failed with this error. It crashed again for the same reason
(not
> yet sure why), but luckily this time commitbox was unchecked before the crash,
> so all is good now.

Thanks for looking into this!

Powered by Google App Engine
This is Rietveld 408576698