Issue 1392173002: Show UsedLocalElements and parts ASTs on the status pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1392173002: Show UsedLocalElements and parts ASTs on the status pages. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Show UsedLocalElements and parts ASTs on the status pages. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/307612582b1591dc22f3932da1020c9a947c2feb

Patch Set 1 #

Total comments: 4

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -16 lines)			Patch
	M	pkg/analysis_server/lib/src/status/get_handler.dart	View		3 chunks	+69 lines, -16 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1392173002/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart File pkg/analysis_server/lib/src/status/get_handler.dart (right): https://codereview.chromium.org/1392173002/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart#newcode589 pkg/analysis_server/lib/src/status/get_handler.dart:589: return; I think we want to "continue" rather ...

5 years, 2 months ago (2015-10-08 04:12:31 UTC) #2

scheglov

5 years, 2 months ago (2015-10-08 04:41:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
307612582b1591dc22f3932da1020c9a947c2feb (presubmit successful).

Expand Messages | Collapse Messages