PerfProvider: Get collection parameters from Finch

chrome/browser/metrics/perf/perf_provider_chromeos.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_METRICS_PERF_PERF_PROVIDER_CHROMEOS_H_
 #define CHROME_BROWSER_METRICS_PERF_PERF_PROVIDER_CHROMEOS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 114 matching lines @@
   // |trigger_event| is the cause of the perf data collection.
   // |result| is the return value of running perf/quipper. It is 0 if successful
   // and nonzero if not successful.
   void ParseOutputProtoIfValid(
       scoped_ptr<WindowedIncognitoObserver> incognito_observer,
       scoped_ptr<SampledProfile> sampled_profile,
       int result,
       const std::vector<uint8>& perf_data,
       const std::vector<uint8>& perf_stat);
 
+  const CollectionParams& collection_params() { return collection_params_; }

[Alexei Svitkine (slow), 2015/10/16 15:37:50]

Nit: Mark the method const as well. Same below.

[dhsharp, 2015/10/19 22:45:28]

Done.

+  const RandomSelector& command_selector() { return command_selector_; }
+
  private:
   static const CollectionParams kDefaultParameters;
 
   // Class that listens for changes to the login state. When a normal user logs
   // in, it updates PerfProvider to start collecting data.
   class LoginObserver : public chromeos::LoginState::Observer {
    public:
     explicit LoginObserver(PerfProvider* perf_provider);
 
     // Called when either the login state or the logged in user type changes.
     // Activates |perf_provider_| to start collecting.
     void LoggedInStateChanged() override;
 
    private:
     // Points to a PerfProvider instance that can be turned on or off based on
     // the login state.
     PerfProvider* perf_provider_;
   };
 
+  // Change the values in |collection_params_| and the commands in
+  // |command_selector_| for any keys that are present in |params|.
+  void SetCollectionParamsFromVariationParams(
+    const std::map<std::string, std::string> &params);

[Alexei Svitkine (slow), 2015/10/16 15:37:50]

Nit: indent 2 more - or maybe just run "git cl format".

[dhsharp, 2015/10/19 22:45:28]

Done.

+
   // Called when a suspend finishes. This is either a successful suspend
   // followed by a resume, or a suspend that was canceled. Inherited from
   // PowerManagerClient::Observer.
   void SuspendDone(const base::TimeDelta& sleep_duration) override;
 
   // Turns on perf collection. Resets the timer that's used to schedule
   // collections.
   void OnUserLoggedIn();
 
   // Called when a session restore has finished.
@@ skipping 68 matching lines @@
 };
 
 // Exposed for unit testing.
 namespace internal {
 
 // Return the default set of perf commands and their odds of selection given
 // the identity of the CPU in |cpuid|.
 std::vector<RandomSelector::WeightAndValue> GetDefaultCommandsForCpu(
     const CPUIdentity& cpuid);
 
+// For the "PerfCommand::"-prefixed keys in |params|, return the cpu specifier
+// that is the narrowest match for the CPU identified by |cpuid|.
+// Valid CPU specifiers, in increasing order of specificity, are:
+// "default", a system architecture (e.g. "x86_64"), a CPU microarchitecture
+// (currently only Intel uarchs supported), or a CPU model name substring.
+std::string FindBestCpuSpecifierFromParams(
+    const std::map<std::string, std::string>& params,
+    const CPUIdentity& cpuid);
+
 }  // namespace internal
 
 }  // namespace metrics
 
 #endif  // CHROME_BROWSER_METRICS_PERF_PERF_PROVIDER_CHROMEOS_H_