Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: ios/web/net/cert_verifier_block_adapter_unittest.cc

Issue 1392143003: Allways call didReceiveAuthenticationChallenge: completion handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Ryan's review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/net/cert_verifier_block_adapter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/net/cert_verifier_block_adapter_unittest.cc
diff --git a/ios/web/net/cert_verifier_block_adapter_unittest.cc b/ios/web/net/cert_verifier_block_adapter_unittest.cc
index f05acf68945f1b15ab00435c5b0a28ad1dec6555..948057108e2a159303a511d371feb0218de1d5e9 100644
--- a/ios/web/net/cert_verifier_block_adapter_unittest.cc
+++ b/ios/web/net/cert_verifier_block_adapter_unittest.cc
@@ -148,4 +148,25 @@ TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndSyncError) {
EXPECT_EQ(kExpectedError, actual_error);
}
+// Tests that the completion handler passed to |Verify()| is called, even if the
+// adapter is destroyed.
+TEST_F(CertVerifierBlockAdapterTest, CompletionHandlerIsAlwaysCalled) {
+ scoped_ptr<net::CertVerifier> verifier(net::CertVerifier::CreateDefault());
+ scoped_ptr<CertVerifierBlockAdapter> test_adapter(
+ new CertVerifierBlockAdapter(verifier.get(), &net_log_));
+
+ // Call |Verify| and destroy the adapter.
+ CertVerifierBlockAdapter::Params params(cert_.get(), kHostName);
+ __block bool verification_completed = false;
+ test_adapter->Verify(params, ^(net::CertVerifyResult, int) {
+ verification_completed = true;
+ });
+ test_adapter.reset();
+
+ // Make sure that the completion handler is called.
+ base::test::ios::WaitUntilCondition(^{
+ return verification_completed;
+ }, base::MessageLoop::current(), base::TimeDelta());
+}
+
} // namespace web
« no previous file with comments | « ios/web/net/cert_verifier_block_adapter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698