Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: ios/web/net/cert_verifier_block_adapter.h

Issue 1392143003: Allways call didReceiveAuthenticationChallenge: completion handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Ryan's review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/net/cert_verifier_block_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/net/cert_verifier_block_adapter.h
diff --git a/ios/web/net/cert_verifier_block_adapter.h b/ios/web/net/cert_verifier_block_adapter.h
index 2646f91797af87df60fef528f45a5e86cf8165e4..e2d473208522b0b19698a38f84acbd5e2c8c305d 100644
--- a/ios/web/net/cert_verifier_block_adapter.h
+++ b/ios/web/net/cert_verifier_block_adapter.h
@@ -30,8 +30,8 @@ class CertVerifierBlockAdapter {
CertVerifierBlockAdapter(net::CertVerifier* cert_verifier,
net::NetLog* net_log);
- // When the verifier is destroyed, all certificate verification requests are
- // canceled, and their completion handlers will not be called.
+ // When the verifier is destroyed, certificate verification requests are not
+ // canceled, and their completion handlers are guaranteed to be called.
~CertVerifierBlockAdapter();
// Encapsulates verification params. |cert| and |hostname| are mandatory, the
@@ -69,12 +69,11 @@ class CertVerifierBlockAdapter {
// Verifies certificate with given |params|. |completion_handler| must not be
// null and can be called either synchronously (in the same runloop) or
// asynchronously.
+ // Note: |completion_handler| is guaranteed to be called, even if the instance
+ // |Verify()| was called on is destroyed.
void Verify(const Params& params, CompletionHandler completion_handler);
private:
- // Pending verification requests. Request must be alive until verification is
- // completed, otherwise verification operation will be cancelled.
- ScopedVector<net::CertVerifier::Request> pending_requests_;
// Underlying unowned CertVerifier.
net::CertVerifier* cert_verifier_;
// Unowned NetLog required by CertVerifier.
« no previous file with comments | « no previous file | ios/web/net/cert_verifier_block_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698