Allways call didReceiveAuthenticationChallenge: completion handler.

ios/web/net/cert_verifier_block_adapter_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/web/net/cert_verifier_block_adapter.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/test/ios/wait_util.h"
 #include "ios/web/public/test/test_web_thread_bundle.h"
 #include "net/base/net_errors.h"
@@ skipping 130 matching lines @@
   // Call |Verify|.
   net::CertVerifyResult actual_result;
   int actual_error = -1;
   CertVerifierBlockAdapter::Params params(cert_.get(), kHostName);
   Verify(&test_adapter, params, &actual_result, &actual_error);
 
   // Ensure that Verification results are correct.
   EXPECT_EQ(kExpectedError, actual_error);
 }
 
+// Tests that |Verify| completion handler is called even if adapter is
+// destroyed.

[Ryan Sleevi, 2015/10/28 18:32:27]

comment nit: Missing some articles

// Tests that the completion handler passed to |Verify()| is called, even if the
adapter is destroyed.

[Eugene But (OOO till 7-30), 2015/10/29 15:43:38]

Done.

+TEST_F(CertVerifierBlockAdapterTest, CompletionHandlerIsAlwaysCalled) {
+  scoped_ptr<net::CertVerifier> verifier(net::CertVerifier::CreateDefault());
+  scoped_ptr<CertVerifierBlockAdapter> test_adapter(
+      new CertVerifierBlockAdapter(verifier.get(), &net_log_));
+
+  // Call |Verify| and destroy adapter.

[Ryan Sleevi, 2015/10/28 18:32:27]

s/destroy adapter/destroy the adapter/

[Eugene But (OOO till 7-30), 2015/10/29 15:43:38]

Done.

+  CertVerifierBlockAdapter::Params params(cert_.get(), kHostName);
+  __block bool verification_completed = false;
+  test_adapter->Verify(params, ^(net::CertVerifyResult, int) {
+    verification_completed = true;
+  });
+  test_adapter.reset();
+
+  // Make sure that completion handler is called.

[Ryan Sleevi, 2015/10/28 18:32:27]

s/that completion/that the completion/

[Eugene But (OOO till 7-30), 2015/10/29 15:43:38]

Done.

+  base::test::ios::WaitUntilCondition(^{
+    return verification_completed;
+  }, base::MessageLoop::current(), base::TimeDelta());
+}
+
 }  // namespace web