Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Unified Diff: util/win/registration_protocol_win.h

Issue 1392093003: win: Capture some CRITICAL_SECTION debugging data (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/win/process_structs.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/registration_protocol_win.h
diff --git a/util/win/registration_protocol_win.h b/util/win/registration_protocol_win.h
index 7c59bcdd38682ca8ec678a09bbc0b81247d04855..9a7bd29688505efd29ceb738a9ac6185725353d0 100644
--- a/util/win/registration_protocol_win.h
+++ b/util/win/registration_protocol_win.h
@@ -49,15 +49,23 @@ struct RegistrationRequest {
//! \brief The PID of the client process.
DWORD client_process_id;
- //! \brief The address, in the client process address space, of an
+ //! \brief The address, in the client process's address space, of an
//! ExceptionInformation structure, used when handling a crash dump
//! request.
WinVMAddress crash_exception_information;
- //! \brief The address, in the client process address space, of an
+ //! \brief The address, in the client process's address space, of an
//! ExceptionInformation structure, used when handling a non-crashing dump
//! request.
WinVMAddress non_crash_exception_information;
+
+ //! \brief The address, in the client process's address space, of a
+ //! `CRITICAL_SECTION` allocated with a valid .DebugInfo field. This can
+ //! be accomplished by using the
+ //! `RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO` flag to
+ //! `InitializeCriticalSectionEx()`. This value can be `0`, however then
+ //! limited lock data will be available in minidumps.
+ WinVMAddress critical_section_address;
};
//! \brief A message only sent to the server by itself to trigger shutdown.
« no previous file with comments | « util/win/process_structs.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698