snapshot/win/process_snapshot_win_test.cc - Issue 1392093003: win: Capture some CRITICAL_SECTION debugging data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/process_snapshot_win_test.cc

Issue 1392093003: win: Capture some CRITICAL_SECTION debugging data (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: reenable !locks test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: snapshot/win/process_snapshot_win_test.cc

diff --git a/snapshot/win/process_snapshot_win_test.cc b/snapshot/win/process_snapshot_win_test.cc

index 35cfc68c25334aaa44e60d1443b5cb638631333a..0c4c3436f7e23156d25b51f6dc40787ca65f3b55 100644

--- a/snapshot/win/process_snapshot_win_test.cc

+++ b/snapshot/win/process_snapshot_win_test.cc

@@ -52,8 +52,8 @@ void TestImageReaderChild(const base::string16& directory_modification) {

ScopedProcessSuspend suspend(child.process_handle());

ProcessSnapshotWin process_snapshot;

- ASSERT_TRUE(process_snapshot.Initialize(child.process_handle(),

- ProcessSuspensionState::kSuspended));

+ ASSERT_TRUE(process_snapshot.Initialize(

+ child.process_handle(), ProcessSuspensionState::kSuspended, 0));

ASSERT_GE(process_snapshot.Modules().size(), 2u);