Re-land "Don't check lfQuality in LOGFONT as it has no effect on rendering""

Re-land "Don't check lfQuality in LOGFONT as it has no effect on rendering""

Re-land change r163507, reverted as r166868 but include a cache for the
text flags, as before the original change, to avoid the performance
penalty that forced us to revert the original change in the first
place.

Remove the LOGFONT lfQuality check in computePaintTextFlags and instead
base the textFlags entierly on the system ClearType settings (and
whether a font is a web font). Skia will then use this information to
pick the appropriate type of font smoothing to apply (if any).

BUG=249099
R=bungeman@chromium.org, leviw@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167045

[eae, 2014-02-11 08:13:09]

On 2014/02/11 04:51:04, eae wrote:

Merge fail, obviously m_paintTextFlags should stay. Will upload new patch in a
bit.

[bungeman-skia, 2014-02-11 15:42:56]

https://codereview.chromium.org/139203009/diff/1/Source/platform/fonts/win/Fo...
File Source/platform/fonts/win/FontPlatformDataWin.cpp (right):

https://codereview.chromium.org/139203009/diff/1/Source/platform/fonts/win/Fo...
Source/platform/fonts/win/FontPlatformDataWin.cpp:118: static int
computePaintTextFlags()
computePaintTextFlags(bool isWebFont)

this is static, how is it calling fontFamilyName()?

https://codereview.chromium.org/139203009/diff/1/Source/platform/fonts/win/Fo...
Source/platform/fonts/win/FontPlatformDataWin.cpp:258: m_paintTextFlags =
computePaintTextFlags(logFont);
computeTextFlags doesn't take a param anymore?

[eae, 2014-02-12 07:51:36]

PTAL

[bungeman-chromium, 2014-02-12 15:32:22]

lgtm

(I'm an actual committer now, so this may actually be good for something.)

[eae, 2014-02-12 21:42:21]

On 2014/02/12 15:32:22, bungeman2 wrote:
> lgtm
> 
> (I'm an actual committer now, so this may actually be good for something.)

About time, congrats!

[eae, 2014-02-12 21:42:26]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-02-12 21:42:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eae@chromium.org/139203009/150001

[commit-bot: I haz the power, 2014-02-12 21:50:26]

Change committed as 167045