Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 139203006: Remove GTM dependency from iOS breakpad_client. (Closed)

Created:
6 years, 10 months ago by justincohen
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove GTM dependency from iOS breakpad_client. GTM isn't necessary for iOS's breakpad client. BUG=339495 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251829

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M breakpad/breakpad.gyp View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
justincohen
Good?
6 years, 10 months ago (2014-01-30 15:51:38 UTC) #1
justincohen
PTAL?
6 years, 10 months ago (2014-02-03 23:24:44 UTC) #2
stuartmorgan
lgtm
6 years, 10 months ago (2014-02-04 15:14:04 UTC) #3
justincohen
Over to mark@ for OWNERS. Mark, I cancelled the CL to roll GTM, and this ...
6 years, 10 months ago (2014-02-04 16:02:17 UTC) #4
Mark Mentovai
Okaaay… LGTM
6 years, 10 months ago (2014-02-04 16:25:00 UTC) #5
justincohen
The CQ bit was checked by justincohen@chromium.org
6 years, 10 months ago (2014-02-18 17:13:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/139203006/50001
6 years, 10 months ago (2014-02-18 17:13:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/139203006/50001
6 years, 10 months ago (2014-02-18 18:22:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/139203006/50001
6 years, 10 months ago (2014-02-18 18:30:01 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 20:43:09 UTC) #10
Message was sent while issue was closed.
Change committed as 251829

Powered by Google App Engine
This is Rietveld 408576698