Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1392023004: Rename android only infobars (Closed)

Created:
5 years, 2 months ago by Evan Stade
Modified:
5 years, 1 month ago
CC:
asanka, cbentzel+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, Michael van Ouwerkerk, phoglund+watch_chromium.org, posciak+watch_chromium.org, tnakamura+watch_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename android only infobars BUG=536129 Committed: https://crrev.com/1ec66410773eefa729c3a1685d75e6de935b3fcb Cr-Commit-Position: refs/heads/master@{#355870}

Patch Set 1 #

Patch Set 2 : update another reference #

Patch Set 3 : rebase #

Patch Set 4 : rebase, attempt to fix #

Patch Set 5 : try again #

Patch Set 6 : try again #

Patch Set 7 : try again #

Patch Set 8 : try again #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -1115 lines) Patch
D chrome/browser/download/download_request_infobar_delegate.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/download/download_request_infobar_delegate.cc View 1 chunk +0 lines, -90 lines 0 comments Download
A + chrome/browser/download/download_request_infobar_delegate_android.h View 5 chunks +11 lines, -11 lines 0 comments Download
A + chrome/browser/download/download_request_infobar_delegate_android.cc View 4 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/download/download_request_infobar_delegate_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/download/download_request_limiter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_request_limiter_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
D chrome/browser/geolocation/geolocation_infobar_delegate.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/geolocation/geolocation_infobar_delegate.cc View 1 chunk +0 lines, -48 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_infobar_delegate_android.h View 1 2 2 chunks +14 lines, -13 lines 2 comments Download
A + chrome/browser/geolocation/geolocation_infobar_delegate_android.cc View 2 chunks +17 lines, -15 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/media/media_stream_infobar_delegate.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/media/media_stream_infobar_delegate.cc View 1 chunk +0 lines, -146 lines 0 comments Download
A + chrome/browser/media/media_stream_infobar_delegate_android.h View 1 2 3 4 3 chunks +10 lines, -9 lines 0 comments Download
A + chrome/browser/media/media_stream_infobar_delegate_android.cc View 1 2 3 4 5 chunks +31 lines, -33 lines 0 comments Download
D chrome/browser/media/midi_permission_infobar_delegate.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/media/midi_permission_infobar_delegate.cc View 1 chunk +0 lines, -48 lines 0 comments Download
A chrome/browser/media/midi_permission_infobar_delegate_android.h View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A + chrome/browser/media/midi_permission_infobar_delegate_android.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/media/permission_bubble_media_access_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/media/protected_media_identifier_infobar_delegate.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/media/protected_media_identifier_infobar_delegate.cc View 1 chunk +0 lines, -62 lines 0 comments Download
A + chrome/browser/media/protected_media_identifier_infobar_delegate_android.h View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
A + chrome/browser/media/protected_media_identifier_infobar_delegate_android.cc View 2 chunks +19 lines, -19 lines 0 comments Download
D chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.cc View 1 chunk +0 lines, -58 lines 0 comments Download
A + chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate_android.h View 3 chunks +9 lines, -8 lines 0 comments Download
A + chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate_android.cc View 2 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/permissions/permission_queue_controller.cc View 3 chunks +16 lines, -16 lines 0 comments Download
D chrome/browser/storage/durable_storage_permission_infobar_delegate.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/storage/durable_storage_permission_infobar_delegate.cc View 1 chunk +0 lines, -48 lines 0 comments Download
A + chrome/browser/storage/durable_storage_permission_infobar_delegate_android.h View 1 2 1 chunk +14 lines, -13 lines 0 comments Download
A + chrome/browser/storage/durable_storage_permission_infobar_delegate_android.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/android/infobars/confirm_infobar.cc View 1 2 3 4 4 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc View 1 2 3 4 5 6 7 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 2 chunks +14 lines, -14 lines 0 comments Download
M components/infobars/core/infobar_delegate.h View 1 4 chunks +3 lines, -2 lines 0 comments Download
M components/infobars/core/infobar_delegate.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392023004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392023004/1
5 years, 2 months ago (2015-10-12 23:00:38 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/143642) linux_chromium_gn_chromeos_rel on ...
5 years, 2 months ago (2015-10-12 23:10:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392023004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392023004/60001
5 years, 1 month ago (2015-10-22 22:39:47 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/135308) android_compile_dbg on ...
5 years, 1 month ago (2015-10-22 22:59:26 UTC) #8
Evan Stade
pkasting: components/infobars/ sky: chrome/ as requested here: https://codereview.chromium.org/1384153003#msg27
5 years, 1 month ago (2015-10-22 23:13:11 UTC) #10
Peter Kasting
RS LGTM
5 years, 1 month ago (2015-10-22 23:22:23 UTC) #11
sky
LGTM
5 years, 1 month ago (2015-10-22 23:25:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392023004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392023004/100001
5 years, 1 month ago (2015-10-23 01:27:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/131353)
5 years, 1 month ago (2015-10-23 01:43:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392023004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392023004/140001
5 years, 1 month ago (2015-10-23 19:19:57 UTC) #20
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 1 month ago (2015-10-23 20:24:31 UTC) #21
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/1ec66410773eefa729c3a1685d75e6de935b3fcb Cr-Commit-Position: refs/heads/master@{#355870}
5 years, 1 month ago (2015-10-23 20:25:19 UTC) #22
mlamouri (slow - plz ping)
https://codereview.chromium.org/1392023004/diff/140001/chrome/browser/geolocation/geolocation_infobar_delegate_android.h File chrome/browser/geolocation/geolocation_infobar_delegate_android.h (right): https://codereview.chromium.org/1392023004/diff/140001/chrome/browser/geolocation/geolocation_infobar_delegate_android.h#newcode16 chrome/browser/geolocation/geolocation_infobar_delegate_android.h:16: class GeolocationInfoBarDelegateAndroidAndroid I think you have one Android too ...
5 years, 1 month ago (2015-10-26 17:11:36 UTC) #24
Evan Stade
5 years, 1 month ago (2015-10-26 18:28:29 UTC) #25
Message was sent while issue was closed. 
https://codereview.chromium.org/1392023004/diff/140001/chrome/browser/geoloca...
File chrome/browser/geolocation/geolocation_infobar_delegate_android.h (right):

https://codereview.chromium.org/1392023004/diff/140001/chrome/browser/geoloca...
chrome/browser/geolocation/geolocation_infobar_delegate_android.h:16: class
GeolocationInfoBarDelegateAndroidAndroid
On 2015/10/26 17:11:36, Mounir Lamouri wrote:
> I think you have one Android too many here.

thanks, created a CL to fix it.

Powered by Google App Engine
This is Rietveld 408576698