Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1391993002: win: Set last-upload-attempt time in CrashReportDatabaseWin (Closed)

Created:
5 years, 2 months ago by Mark Mentovai
Modified:
5 years, 2 months ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Set last-upload-attempt time in CrashReportDatabaseWin This resolves some left-behind TODOs referring to a closed bug. It looks like this should have worked since dfaa25af4929. BUG=crashpad:13 TEST=crashpad_snapshot_test CrashReportDatabaseTest.* R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1f11ddc785ba2616aec7aa4cf4021dccc1216a1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -30 lines) Patch
M client/crash_report_database_test.cc View 6 chunks +0 lines, -16 lines 0 comments Download
M client/crash_report_database_win.cc View 4 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 2 months ago (2015-10-07 17:41:35 UTC) #2
scottmg
lgtm
5 years, 2 months ago (2015-10-07 17:46:50 UTC) #3
Mark Mentovai
5 years, 2 months ago (2015-10-07 18:00:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f11ddc785ba2616aec7aa4cf4021dccc1216a1e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698