Correctly record and pass around navigation start time.

components/web_view/frame.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/web_view/frame.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 78 matching lines @@
   if (view_) {
     view_->ClearLocalProperty(kFrame);
     if (view_ownership_ == ViewOwnership::OWNS_VIEW)
       view_->Destroy();
   }
   tree_->delegate_->DidDestroyFrame(this);
 }
 
 void Frame::Init(Frame* parent,
                  mojo::ViewTreeClientPtr view_tree_client,
-                 mojo::InterfaceRequest<mojom::Frame> frame_request) {
+                 mojo::InterfaceRequest<mojom::Frame> frame_request,
+                 base::TimeTicks navigation_start_time) {
   {
     // Set the FrameClient to null so that we don't notify the client of the
     // add before OnConnect().
     base::AutoReset<mojom::FrameClient*> frame_client_resetter(&frame_client_,
                                                                nullptr);
     if (parent)
       parent->Add(this);
   }
 
+  navigation_start_time_ = navigation_start_time;
   const ClientType client_type = frame_request.is_pending()
                                      ? ClientType::NEW_CHILD_FRAME
                                      : ClientType::EXISTING_FRAME_NEW_APP;
   InitClient(client_type, nullptr, view_tree_client.Pass(),
              frame_request.Pass());
 
   tree_->delegate_->DidCreateFrame(this);
 
   DVLOG(2) << "Frame id=" << id_ << " parent=" << (parent_ ? parent_->id_ : 0)
            << " app_id=" << app_id_ << " this=" << this;
@@ skipping 79 matching lines @@
   if (client_type == ClientType::NEW_CHILD_FRAME) {
     // Don't install an error handler. We allow for the target to only
     // implement ViewTreeClient.
     // This frame (and client) was created by an existing FrameClient. There
     // is no need to send it OnConnect().
     frame_binding_.reset(
         new mojo::Binding<mojom::Frame>(this, frame_request.Pass()));
     frame_client_->OnConnect(
         nullptr, tree_->change_id(), id_, mojom::VIEW_CONNECT_TYPE_USE_NEW,
         mojo::Array<mojom::FrameDataPtr>(),
+        navigation_start_time_.ToInternalValue(),
         base::Bind(&OnConnectAck, base::Passed(&data_and_binding)));
+    navigation_start_time_ = base::TimeTicks();
   } else {
     std::vector<const Frame*> frames;
     tree_->root()->BuildFrameTree(&frames);
 
     mojo::Array<mojom::FrameDataPtr> array(frames.size());
     for (size_t i = 0; i < frames.size(); ++i)
       array[i] = FrameToFrameData(frames[i]).Pass();
 
     mojom::FramePtr frame_ptr;
     // Don't install an error handler. We allow for the target to only
     // implement ViewTreeClient.
     frame_binding_.reset(
         new mojo::Binding<mojom::Frame>(this, GetProxy(&frame_ptr).Pass()));
     frame_client_->OnConnect(
         frame_ptr.Pass(), tree_->change_id(), id_,
         client_type == ClientType::EXISTING_FRAME_SAME_APP
             ? mojom::VIEW_CONNECT_TYPE_USE_EXISTING
             : mojom::VIEW_CONNECT_TYPE_USE_NEW,
-        array.Pass(),
+        array.Pass(), navigation_start_time_.ToInternalValue(),
         base::Bind(&OnConnectAck, base::Passed(&data_and_binding)));
+    navigation_start_time_ = base::TimeTicks();
     tree_->delegate_->DidStartNavigation(this);
 
     // We need |embedded_connection_id_| is order to validate requests to
     // create a child frame (OnCreatedFrame()). Pause incoming methods until
     // we get the id to prevent race conditions.
     if (embedded_connection_id_ == kInvalidConnectionId)
       frame_binding_->PauseIncomingMethodCallProcessing();
   }
 }
 
@@ skipping 96 matching lines @@
 
   pending_navigate_.reset();
 
   // We need a View to navigate. When we get the View we'll complete the
   // navigation.
   if (!view_) {
     pending_navigate_ = request.Pass();
     return;
   }
 
+  navigation_start_time_ =

[sky, 2015/10/14 22:46:24]

Does navigation_start_time_ need to be a member? Can it be passed to
OnCanNavigationFrame?

[yzshen1, 2015/10/14 22:59:15]

In that case we also need to pass it to ChangeClient, OnWillNavigateAck,
InitClient. I feel that it seems easier to have a member variable. What do you
think? Thanks!

[sky, 2015/10/14 23:08:36]

The problem with the member is that it's easy to accidentally reset and end up
using the wrong value. By passing the value around it's clear the value
corresponds to a particular navigation.

[yzshen1, 2015/10/15 00:05:10]

Done.

+      base::TimeTicks::FromInternalValue(request->originating_time_ticks);
   // Drop any pending navigation requests.
   navigate_weak_ptr_factory_.InvalidateWeakPtrs();
 
   DVLOG(2) << "Frame::StartNavigate id=" << id_ << " url=" << request->url;
 
   const GURL requested_url(request->url);
   tree_->delegate_->CanNavigateFrame(
       this, request.Pass(),
       base::Bind(&Frame::OnCanNavigateFrame,
                  navigate_weak_ptr_factory_.GetWeakPtr(), requested_url));
@@ skipping 216 matching lines @@
                                               final_update);
 }
 
 void Frame::OnFindInPageSelectionUpdated(int32_t request_id,
                                          int32_t active_match_ordinal) {
   tree_->delegate_->OnFindInPageSelectionUpdated(request_id, this,
                                                  active_match_ordinal);
 }
 
 }  // namespace web_view