Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1391953003: Fix evaluation in frames with _private variable names. (Closed)

Created:
5 years, 2 months ago by turnidge
Modified:
5 years, 2 months ago
Reviewers:
Cutch, rmacnak
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix evaluation in frames with _private variable names. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/3388f2dc982966f9eb239d18d9de02fee6749fb9

Patch Set 1 #

Patch Set 2 : edits #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -29 lines) Patch
M runtime/observatory/tests/service/eval_test.dart View 1 2 3 chunks +7 lines, -29 lines 0 comments Download
A runtime/observatory/tests/service/evaluate_in_frame_rpc_test.dart View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +8 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
turnidge
5 years, 2 months ago (2015-10-07 17:40:13 UTC) #2
Cutch
5 years, 2 months ago (2015-10-07 17:41:52 UTC) #3
Cutch
lgtm
5 years, 2 months ago (2015-10-07 17:42:18 UTC) #4
rmacnak
https://codereview.chromium.org/1391953003/diff/40001/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/1391953003/diff/40001/runtime/vm/debugger.cc#newcode1031 runtime/vm/debugger.cc:1031: bool IsPrivateVariableName(const String& var_name) { Library::IsPrivate already exists and ...
5 years, 2 months ago (2015-10-07 18:06:21 UTC) #6
turnidge
5 years, 2 months ago (2015-10-07 18:09:48 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
3388f2dc982966f9eb239d18d9de02fee6749fb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698