third_party/WebKit/Source/core/layout/LayoutReplica.cpp - Issue 1391943005: Document reflection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutReplica.cpp

Issue 1391943005: Document reflection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed the TODO. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutReplica.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutReplica.cpp b/third_party/WebKit/Source/core/layout/LayoutReplica.cpp

index 84714aaa99f8569865d156de9940ff8e7dae64ba..c2c404d2c946b9addb2df146fea6323a69aeb068 100644

--- a/third_party/WebKit/Source/core/layout/LayoutReplica.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutReplica.cpp

@@ -64,8 +64,9 @@ void LayoutReplica::layout()

void LayoutReplica::computePreferredLogicalWidths()

{

- m_minPreferredLogicalWidth = parentBox()->size().width();

- m_maxPreferredLogicalWidth = m_minPreferredLogicalWidth;

+ // LayoutReplica is a synthetic object, PaintLayerReflectionInfo is what

+ // calls into it, so this should never be called.

+ ASSERT_NOT_REACHED();

clearPreferredLogicalWidthsDirty();

}